Le 13/03/2015 14:43, Raphaël Ouazana-Sustowski a écrit :
Hi,
Le 2015-03-13 11:01, Jephte Clain a écrit :
Le 12/03/2015 15:00, Jephte Clain a écrit :
for instance, I'm looking for a way to DISABLE the delimiter. some
users
have a ";" in their passwords. I cannot know in advance what
characters may
be used, so I'd like to disable the feature entirely
is this even possible? the doc says about defaultDelimiter:
"This is the value used to split multiple values when are provided
as a
single one. Each attribute definition (see below) can define its own
delimiter, but this attribute define the default one : "
- it says "see below": where exactly? I don't find any info about
delimiter
in attribute definition
- it doesn't tell how to disable it
You can't disable it.
how unfortunate :-(
I'm seriously considering if LSC is the right tool for us...
Are we really the first ones to have this kind of problems?
hello,
I took the time to somewhat dive into LSC 2.1.3 source
Value splitting is done *only* for MERGE and CREATE policies. With
FORCE, the value is copied as is. So initially setting the password
with <createValues> triggers (what I consider) the bug
I guess very few people initialize password with <createValue>. This
would explain why we are the first to hit this bug.
- I consider it a bug because delimiter is ignored for forceValues,
contrary to what the doc says
- But I still think that one should be allowed to disable delimiter or
defaultDelimiter. BeanComparator is already designed to handle this
situation because it checks delimiter != null
If you think there is a bug, can you please open a bug on the forge:
http://tools.lsc-project.org/projects/lsc/issues
yes I know. I posted to the list first to have an opinion: is this the
right way to do it? are there any consequences I could have missed?
I attach two simple patches. They are based on LSC 2.1.3 source tree
- the first one allows defaultDelimiter to be null (i.e.
<defaultDelimiter></defaultDelimiter> or <defaultDelimiter/>)
When both defaultDelimiter and delimiter are null, they are ignored,
i.e. there is no delimiter.
A quick test shows no evident problem and solve my problem. If you
consider it worthy, I will submit it to the forge
note: the patch only updates src/main/resources/schemas/lsc-core-2.1.xsd
the dependent file
src/main/java/org/lsc/configuration/PropertiesBasedSyncOptionsType.java
is regenerated with mvn package
Thank you for your work. As said earlier, you should open a bug to let
us track this issue.
Anyway I don't think we can change this behaviour in a minor version,
because some people can expect the default value to be defined. Maybe we
can include this for next 2.2 version.
done: bug #762
- The second one enable value splitting with <forceValues>. I didn't
test it, so it needs reviews before considered worthy
A second bug report for this would be great.
bug #763
Regards,
Raphaël Ouazana.
--
Jephté CLAIN | Développeur / Intégrateur d'applications
Service Systèmes d'Information http://dsiun.univ-reunion.fr
Tel: +262 262 93 86 31 || Mobile: +262 692 29 58 24 ||
http://www.univ-reunion.fr
_______________________________________________________________
Ldap Synchronization Connector (LSC) - http://lsc-project.org
lsc-users mailing list
[email protected]
http://lists.lsc-project.org/listinfo/lsc-users
