Hi Aijun, Thanks for your reply. You’re right of course that the introduction has some description of what the extensions are for, I don’t think any more editing is needed there. I would prefer to see a sentence in the abstract as well, since for some people the abstract is the only look they’ll take at the document and for them, the question of “what is it for?” isn’t answered. I don’t insist on this, but I recommend it. The additional sentence, if you choose to add it, could be something like “this information does not change route computation but is expected to be useful for network analysis and troubleshooting”.
I don’t think there is any need to re-introduce the text or appendix the WG removed. Thanks, —John On Apr 6, 2021, at 10:01 PM, Aijun Wang <[email protected]<mailto:[email protected]>> wrote: Hi, John: Thanks for your review. Let me respond your concern for the usages of such information first. Ketan, Acee and other co-authors may respond you other comments. Actually, there are use case descriptions in the previous version of this draft, please refer tohttps://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospf-prefix-originator-05<https://urldefense.com/v3/__https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospf-prefix-originator-05__;!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKK7B8Auzw$>. Section 4<https://urldefense.com/v3/__https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospf-prefix-originator-05*section-4__;Iw!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKLXA-I2NQ$> and section 5<https://urldefense.com/v3/__https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospf-prefix-originator-05*section-5__;Iw!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKKIUz4-AQ$> of this version describes its uses for inter-area topology recovery and external prefix source determination. After discussion within the WG, we removes the use case descriptions within the body of the document, just keep some short descriptions as that in the introduction part of the current version: “This document proposes extensions to the OSPF protocol for inclusion of information associated with the router originating the prefix along with the prefix advertisement. These extensions do not change the core OSPF route computation functionality. They provide useful information for topology analysis and traffic engineering, especially on a controller when this information is advertised as an attribute of the prefixes via mechanisms such as Border Gateway Protocol Link- State (BGP-LS)” Do you think it is enough? There is also one Appendix<https://urldefense.com/v3/__https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospf-prefix-originator-05*appendix-A__;Iw!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKJ6qMsiHQ$> in the version 05 of this document, to describe clearly the usage of such prefix originator information, but was opposed by some experts during the WG last call. Do we need to add back to them? I think they are helpful for the usage and deployment of this document. And, such use case is the main start point of this document. Thanks in advance. Best Regards Aijun Wang China Telecom -----Original Message----- From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> On Behalf Of John Scudder via Datatracker Sent: Wednesday, April 7, 2021 5:06 AM To: The IESG <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]> Subject: [Lsr] John Scudder's Discuss on draft-ietf-lsr-ospf-prefix-originator-10: (with DISCUSS and COMMENT) John Scudder has entered the following ballot position for draft-ietf-lsr-ospf-prefix-originator-10: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html<https://urldefense.com/v3/__https://www.ietf.org/iesg/statement/discuss-criteria.html__;!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKKz0tebDA$> for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-lsr-ospf-prefix-originator/<https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-ietf-lsr-ospf-prefix-originator/__;!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKJTFeK0qw$> ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- Although the document is largely clear and well-written (thanks for that), I was left with one burning question: what are these sub-TLVs *for*? There’s no specification for what the router is supposed to do with them, only how to originate them. The only clue I get is buried down in Section 5: The identification of the node that is originating a specific prefix in the network may aid in debugging of issues related to prefix reachability within an OSPF network. If their purpose is to act as debugging aids, I think you should at least say so briefly in the abstract and introduction. If they have some purpose beyond that, it’s missing from the doc. ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- 1. Section 2: This document defines the Prefix Source OSPF Router-ID and the Prefix Source Router Address Sub-TLVs for inclusion of the Router ID and a reachable address information for the router originating the prefix as a prefix attribute. I found this sentence difficult to read. I think removing the redundant word “information” would help a little. Beyond that, it might help to break it into a couple sentences, as in: “This document defines the Prefix Source OSPF Router-ID and the Prefix Source Router Address Sub-TLVs. They are used, respectively, to include the Router ID of, and a reachable address of, the router that originates the prefix as a prefix attribute.” 2. Section 2.1: For intra-area prefix advertisements, the Prefix Source OSPF Router- ID Sub-TLV MUST be considered invalid and ignored if the OSPF Router ID field is not the same as Advertising Router field in the containing LSA. Similar validation cannot be reliably performed for inter-area and external prefix advertisements. What does it mean for the sub-TLV to be ignored? Since you haven’t specified any processing of the Sub-TLVs, there’s seemingly no ignoring to be done locally — so does this mean the sub-TLV isn’t even supposed to be stored? Flooded? 3. Section 3: If the originating node is advertising an OSPFv2 Router Address TLV [RFC3630] or an OSPFv3 Router IPv6 Address TLV [RFC5329], then the same address MUST be used in the Router Address field of the Prefix Source Router Address Sub-TLV. When the originating node is not advertising such an address, implementations can determine a unique and reachable address (i.e., advertised with the N-flag set [RFC7684] or N-bit set [RFC8362]) belonging to the originating node to set in the Router Address field. As I read this, if there’s no Router Address TLV, then the implementation has to use something it advertised with the N-flag set. I infer this because you used “i.e.” (which essentially means “in other words”). If you do mean the parenthetical to be limiting, why not make it a MUST? If you don’t mean it to be limiting, shouldn’t it be “e.g.” or better still, “for example”? (Looking at RFC 7684 it doesn’t seem as though it should be limiting, because RFC 7684 § 2.1 says the N-flag is optional even for local routes.) 4. Section 3: When an ABR generates inter-area prefix advertisements into its non- backbone areas corresponding to an inter-area prefix advertisement from the backbone area, the only way to determine the originating node information is based on the Prefix Source OSPF Router-ID and Prefix Source Router Address Sub-TLVs present in the inter-area prefix advertisement originated into the backbone area by an ABR from another non-backbone area. The ABR performs its prefix calculation to determine the set of nodes that contribute to the best prefix reachability. It MUST use the prefix originator information only from this set of nodes. The ABR MUST NOT include the Prefix Source OSPF Router-ID or the Prefix Source Router Address Sub-TLVs when it is unable to determine the information of the best originating node. What is it supposed to do if there are N contributing routes but it can only determine the information for M < N of the contributors? Also, should “node” be “nodes” (last word of last sentence)? 5. Section 5, nit: Consideration should be given to the operation impact of the increase s/operation/operational/ _______________________________________________ Lsr mailing list [email protected]<mailto:[email protected]> https://www.ietf.org/mailman/listinfo/lsr<https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/lsr__;!!NEt6yMaO-gk!WeC6Da_Z-_FpiT5W-54Gss2gYdZ3WdksZhd7RWfkbQ3Zh8AanentfKJcqk9Wig$>
_______________________________________________ Lsr mailing list [email protected] https://www.ietf.org/mailman/listinfo/lsr
