Hi all, I wanted to share some additional feedback now that I've implemented the updated module.
First, the "uses ospf:ospf-router-lsa-bits" statement should be removed from the "inter-router-tlv" container since the Inter-Area-Router TLV doesn't contain the "Router-LSA bits" field. Next, in the "ospfv3-lsa-prefix" grouping, I think the "prefix-length" leaf is unnecessary as that information is already included in the "prefix" leaf. I think the "ospfv3-lsa-prefix" grouping from the base module could be reused since it's identical, except it doesn't include the "prefix-length" leaf. Lastly, this might just be a small nitpick of mine, but I don't think having a "length" leaf for all TLVs and Sub-TLVs adds much value. In my opinion, it's only relevant for unknown TLVs that couldn't be decoded; otherwise, it just adds unnecessary noise. If we take a look at the IS-IS model, for instance, we can see that it doesn't have a "length" leaf for the LSP TLVs and Sub-TLVs. By the way, I've generated some sample data using the updated module. Feel free to check it out here: http://westphal.com.br/holo/ospfv3-topo/ You can find the project link here: https://github.com/rwestphal/holo Thanks and regards, Renato. Em qui., 29 de jun. de 2023 às 07:06, <[email protected]> escreveu: > > > A New Internet-Draft is available from the on-line Internet-Drafts > directories. This Internet-Draft is a work item of the Link State Routing > (LSR) WG of the IETF. > > Title : YANG Model for OSPFv3 Extended LSAs > Authors : Acee Lindem > Sharmila Palani > Yingzhen Qu > Filename : draft-ietf-lsr-ospfv3-extended-lsa-yang-20.txt > Pages : 31 > Date : 2023-06-29 > > Abstract: > This document defines a YANG data model augmenting the IETF OSPF YANG > model to provide support for OSPFv3 Link State Advertisement (LSA) > Extensibility as defined in RFC 8362. OSPFv3 Extended LSAs provide > extensible TLV-based LSAs for the base LSA types defined in RFC 5340. > > The IETF datatracker status page for this Internet-Draft is: > https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/ > > There is also an HTML version available at: > https://www.ietf.org/archive/id/draft-ietf-lsr-ospfv3-extended-lsa-yang-20.html > > A diff from the previous version is available at: > https://author-tools.ietf.org/iddiff?url2=draft-ietf-lsr-ospfv3-extended-lsa-yang-20 > > Internet-Drafts are also available by rsync at rsync.ietf.org::internet-drafts > > > _______________________________________________ > Lsr mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/lsr -- Renato Westphal _______________________________________________ Lsr mailing list [email protected] https://www.ietf.org/mailman/listinfo/lsr
