Loa and all, I've read the draft, and found what looks as an obvious typo in the following sentence in Section 8 (highlighted):
In the absence of cryptographic authentication, as IS-IS does not run over IP but directly over the link layer, it's considered difficult to inject false SNP/IHH without having access to the link layer. It should be: In the absence of cryptographic authentication, as IS-IS does not run over IP but directly over the link layer, it's considered difficult to inject false SNP/IIH without having access to the link layer. Lots of thanks to the authors for a very readable document and to Loa for an excellent review. Regards, Sasha From: Lsr <[email protected]> On Behalf Of Loa Andersson Sent: Saturday, October 7, 2023 7:32 PM To: [email protected] Cc: [email protected]; [email protected]; lsr-chairs <[email protected]>; [email protected]; [email protected] Subject: [EXTERNAL] [Lsr] RtgDir Last Call review: draft-ietf-lsr-isis-fast-flooding Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see https://wiki.ietf.org/en/group/rtg/RtgDir<https://wiki.ietf.org/en/group/rtg/RtgDir> Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-lsr-isis-fast-flooding (the current version is -05) Reviewer: Loa Andersson Review Date: 2023-10-08 IETF LC End Date: Intended Status: Experimental Summary: This document is basically ready for publication; I only found one issue - the number of authors listed. Document Overview: Current Link State Protocol Data Unit (PDU) flooding rates are much slower than what modern networks can support. The use of IS-IS at larger scale requires faster flooding rates to achieve desired convergence goals. This document discusses the need for faster flooding, the issues around faster flooding, and some example approaches to achieve faster flooding. It also defines protocol extensions relevant to faster flooding. Comments: The draft is well-written and easy to read. I gone over the IANA Considerations and allocations, and not found anything that need to be addressed. Major Issues: Number of authors: There are 7 authors, that is more the the "allowed" 5 authors. I have no background why there 7 authors listed, this has to be addressed in some way: - reduce the number of authors to five - keep the number of authors at seven, and the Shepherd will have to address this in the SWU, I have put this as a "major issue" since I don't know where to put it. My personal opinion is that anyone that has contributed text to the document, and participated in the authors discussions, should be listed as an author. "No minor issues found." Nits: The nits-tool only finds a Miscellaneous warning: -- The document date (5 September 2023) is 32 days in the past. Is this intentional? This warning is a bit annoying since it is impossible to avoid. I have not found any other nits. /Loa -- Loa Andersson email: [email protected]<mailto:[email protected]> Senior MPLS Expert [email protected]<mailto:[email protected]> Bronze Dragon Consulting phone: +46 739 81 21 64 _______________________________________________ Lsr mailing list [email protected]<mailto:[email protected]> https://www.ietf.org/mailman/listinfo/lsr<https://www.ietf.org/mailman/listinfo/lsr> Disclaimer This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.
_______________________________________________ Lsr mailing list [email protected] https://www.ietf.org/mailman/listinfo/lsr
