Hi Reshad, Thanks for the review.
I'll look into this issue and get back to you soon. We should definitely try to keep these two models consistent. Thanks, Yingzhen On Tue, Nov 14, 2023 at 6:55 AM Reshad Rahman <reshad= [email protected]> wrote: > Hi, > > My suggestion is that authors of these 2 documents spend some time > together to try to align the 2 documents. After that we can do YD review. > > Regards, > Reshad. > > On Wednesday, November 1, 2023, 10:58:56 AM EDT, Reshad Rahman < > [email protected]> wrote: > > > Hi, > > Background: those 2 documents have just been assigned YD review, I am > reviewing OSPF and Jan is reviewing ISIS. > > Was an effort made to keep those 2 documents aligned/in-sync where > possible/desirable? My expectation is that the SR specifics would be > near-identical in the 2 documents. e.g. shouldn't the capabilities for the > 2 protocols be very similar. > Here are some differences which don't seem justified: > - sr-algorithm in ISIS is a uint8 and in OSPF is an identityref > - range-size is a uint32 in ISIS and is a uint24 in OSPF > > > augment /rt:routing/rt:control-plane-protocols > /rt:control-plane-protocol/isis:isis/isis:database > /isis:levels/isis:lsp/isis:router-capabilities: > +--ro sr-capability > | +--ro sr-capability > | | +--ro sr-capability-bits* identityref > | +--ro global-blocks > | +--ro global-block* [] > | +--ro range-size? uint32 > | +--ro sid-sub-tlv > | +--ro sid? uint32 > +--ro sr-algorithms > | +--ro sr-algorithm* uint8 > +--ro local-blocks > | +--ro local-block* [] > | +--ro range-size? uint32 > | +--ro sid-sub-tlv > | +--ro sid? uint32 > +--ro srms-preference > +--ro preference? uint8 > > > augment /rt:routing/rt:control-plane-protocols > /rt:control-plane-protocol/ospf:ospf/ospf:areas/ospf:area > /ospf:interfaces/ospf:interface/ospf:database > /ospf:link-scope-lsa-type/ospf:link-scope-lsas > /ospf:link-scope-lsa/ospf:version/ospf:ospfv2/ospf:ospfv2 > /ospf:body/ospf:opaque/ospf:ri-opaque: > +--ro sr-algorithm-tlv > | +--ro sr-algorithm* identityref > +--ro sid-range-tlvs > | +--ro sid-range-tlv* [] > | +--ro range-size? rt-types:uint24 > | +--ro sid-sub-tlv > | +--ro sid? uint32 > +--ro local-block-tlvs > | +--ro local-block-tlv* [] > | +--ro range-size? rt-types:uint24 > | +--ro sid-sub-tlv > | +--ro sid? uint32 > +--ro srms-preference-tlv > +--ro preference? uint8 > > > > Disclaimer: I don't follow LSR... > > Regards, > Reshad. > _______________________________________________ > Lsr mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/lsr >
_______________________________________________ Lsr mailing list [email protected] https://www.ietf.org/mailman/listinfo/lsr
