Hi Renato, I have incorporated your comments. We are targeting get the base IS-IS and OSPF flex-algo models completed first.
> On Sep 24, 2025, at 7:48 PM, Renato Westphal <[email protected]> wrote: > > Hi all, > > I'd like to share some feedback after implementing the > ietf-isis-remaining-lifetime and ietf-isis-msd YANG modules in Holo Routing. > > 1 - Some augmentation paths are incorrect. Here's a path that fixes them: > https://pastebin.com/raw/kA95b5sU Fixed the first one, the other two had already been fixed - I think you'd sent those before. > > 2 - The "msd-type" leaves use an identityref type whose base is > "iana-msd-types:msd-base-mpls". I see two issues here: first, the MSD > signaling specified by RFC 8491 isn't restricted to MPLS MSDs. Second, by > using an identityref, unknown MSD types cannot be represented. For this > reason, I think using a uint8 for the "msd-type" leaves would be better, as > was done in the OSPF module. Actually, the OSPF MSD model had both the identityref and the unit8. I added the raw value to the grouping. > > 3 - RFC 7987 ("IS-IS Minimum Remaining Lifetime") Section 3.2 says: > > "As a diagnostic aid, an implementation MAY wish to retain the value of the > Remaining Lifetime received when the LSP was added to the LSPDB." > > In holo-isis.yang I added the following augmentation: > > augment "/rt:routing/rt:control-plane-protocols/" > + "rt:control-plane-protocol/isis:isis/isis:database/" > + "isis:levels/isis:lsp" { > leaf received-remaining-lifetime { > type uint16; > units "seconds"; > description > "Remaining lifetime of this LSP at the time it was received."; > } > } > > I suggest incorporating this augmentation into the > ietf-isis-remaining-lifetime module, as that information can be useful when > troubleshooting LSP lifetime corruption issues. I agree and have added it. Thanks, Acee > > Let me know what you think. > > Best Regards, > -- > Renato Westphal > _______________________________________________ > Lsr mailing list -- [email protected] > To unsubscribe send an email to [email protected] _______________________________________________ Lsr mailing list -- [email protected] To unsubscribe send an email to [email protected]
