Hi Ranato, Thanks for reviewing!!!
> On Jun 28, 2026, at 7:12 AM, Renato Westphal <[email protected]> wrote: > > Hi, > > A few points that came up during implementation: > > 1. The FAD sub-TLV augmentation targets the router-capabilities > container instead of the router-capability list nested under it. The > "uses fad-tlvs" should hang off the list entry. I agree - good catch. > 2. The three admin-group sub-TLV groupings model the same value > inconsistently: fa-ex-ag-sub-tlv uses te-types:extended-admin-group, > while fa-in-any-ag-sub-tlv and fa-in-all-ag-sub-tlv use uint64. I > believe the intention is that all three should use > te-types:extended-admin-group. Yes - I missed these when addressing Med's comment. Will fix. > 3. Since that type resolves to a hex-string, I believe a single leaf > would be preferable to a leaf-list. At first I didn't agree with this but I see this constraint for the sub-TLVs containing extended-admin groups in RFC 9350: The IS-IS FAEAG sub-TLV MUST NOT appear more than once in a single IS-IS FAD sub-TLV. If it appears more than once, the IS-IS FAD sub-TLV MUST be ignored by the receiver. Hence, we are in agreement that this is the reason for using a YANG leaf rather than a leaf-list (not the fact that te-type:extended-admin-group maps to a hex-string). Right? Thanks, Acee Thanks, Acee > > Best regards, > Renato > > > Em sáb., 27 de jun. de 2026 às 21:09, <[email protected]> escreveu: >> >> Internet-Draft draft-ietf-lsr-isis-flex-algo-yang-14.txt is now available. It >> is a work item of the Link State Routing (LSR) WG of the IETF. >> >> Title: A YANG Data Model for IS-IS Application-Specific Link Attributes >> and Flexible Algorithm >> Authors: Yingzhen Qu >> Acee Lindem >> Madhavi Joshi >> Name: draft-ietf-lsr-isis-flex-algo-yang-14.txt >> Pages: 35 >> Dates: 2026-06-27 >> >> Abstract: >> >> This document defines a YANG data model to support IS-IS Application- >> Specific Link Attributes and Flexible Algorithm. >> >> The IETF datatracker status page for this Internet-Draft is: >> https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-flex-algo-yang/ >> >> There is also an HTML version available at: >> https://www.ietf.org/archive/id/draft-ietf-lsr-isis-flex-algo-yang-14.html >> >> A diff from the previous version is available at: >> https://author-tools.ietf.org/iddiff?url2=draft-ietf-lsr-isis-flex-algo-yang-14 >> >> Internet-Drafts are also available by rsync at: >> rsync.ietf.org::internet-drafts >> >> >> _______________________________________________ >> Lsr mailing list -- [email protected] >> To unsubscribe send an email to [email protected] > > > > -- > Renato Westphal > > _______________________________________________ > Lsr mailing list -- [email protected] > To unsubscribe send an email to [email protected] _______________________________________________ Lsr mailing list -- [email protected] To unsubscribe send an email to [email protected]
