Issue #400 has been updated by Clément OUDOT.

Target version changed from self-service-password-? to self-service-password-1.0

See https://github.com/ltb-project/self-service-password/issues/35
----------------------------------------
Feature #400: All empty forms display a warning message
http://tools.lsc-project.org/issues/400

Author: Gene Wood
Status: Assigned
Priority: Normal
Assigned to: Clément OUDOT
Category: Self Service Password
Target version: self-service-password-1.0


Currently, the logic in SSP results in every page, when first displayed to the 
user, showing an error message of "Your login is required". This is a poor user 
experience and a bit confusing. Before a user attempts to fill in a form, they 
should not see an error message.

I've put together a fix for this which does the following :
* After all of the POST/GET parameters are validated on the various pages 
(change.php, setquestions.php, etc), a final check is done which checks to see 
if *all* expected fields are not set (! isset()). If *all* fields are unset, we 
don't need to show the user an error message saying that the fields are empty, 
instead display a title in the "$result" div.
* Set "$result" to a new message that merely explains what the page is.
* Add in the 4 title messages to the localizations (currently I've filled in 
English)

This will be a much better experience than having a red warning message with a 
triangle exclamation point icon *every* time a user uses any page in SSP.

See my attached patch which implements this.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://tools.lsc-project.org/my/account
_______________________________________________
ltb-dev mailing list
[email protected]
http://lists.ltb-project.org/listinfo/ltb-dev

Reply via email to