On Tue, 18 Sep 2007 08:57:55 -0700 Randy Dunlap wrote: > On Mon, 17 Sep 2007 14:15:49 -0700 Andrew Morton wrote: > > > > > ltp-full-20070831 has a printf problem: > > > > pth_str03 0 INFO : thread %d exiting, depth=%d, status=%d, addr=%p > > pth_str03 0 INFO : thread %d exiting, depth=%d, status=%d, addr=%p > > --- > The var_args expander in lib/tst_res.c is easily confused. > > Sometimes the varargs expander decides that it shouldn't expand more varargs. > This fixes pth_str03 output but may adversely affect other test output. > > This patch identifies the problem. > I'll run a full LTP test run both with and without the patch and compare the > output files, but if anyone has a better patch for the varargs expander, > that would be nice too. > ---
I don't see any significant differences in the test results output without vs. with the patch to lib/tst_res.c. I would be happy for someone to compare the output logs at http://www.xenotime.net/linux/logs/ : run1.out is without the patch and run2.out is with the patch. There are some pid, threadid, filename, memory usage, and timing differences, and some differences in the order of the output, as well as corrections to the %d etc. erroneous output. Otherwise the patch looks good to me. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
