Subrata Modak wrote:
> I like this part most. You should always ensure backward compatibility
> when you do some modification. I will see to this match. Meanwhile, can
> you also share the results of Ballista run post patching.
Strange, I triggered some problems while building ballista.
However this compatibility patch does not hurt:
Function Num. tests (#Setup Fail) | Restart
Abort Total
-------- ---------- ------------- | ---------
--------- ---------
execl 7964 ( 2212) | 0.0000%
0.0000% 0.0000%
execle 7964 ( 2212) | 0.0000%
0.0000% 0.0000%
execlp 7964 ( 2212) | 0.0000%
0.0000% 0.0000%
fcntl 3971 ( 0) | 0.0000%
0.0000% 0.0000%
mremap 3926 ( 0) | 0.0000%
0.0000% 0.0000%
open 8004 ( 1777) | 0.0000%
0.0000% 0.0000%
prctl 4034 ( 0) | 0.0000%
0.0000% 0.0000%
sem_open 1976 ( 469) | 0.0000%
0.0000% 0.0000%
syscall 25 ( 0) | 0.0000%
0.0000% 0.0000%
sysfs 4003 ( 0) | 0.0000%
0.0000% 0.0000%
-----------------------------------------------------------------------------------------------
(OpenSUSE 10.3, 2.6.16.57-0.7-default, i386)
Some of this errors are (ltp-full-20071231):
/usr/include/unistd.h:656: error: too many arguments to function ‘int
getgroups(int, __gid_t*)’
executeTestCase.cpp:108: error: at this point in file
make: *** [executeTestCase.o] Error 1
executeTestCase.cpp: In function ‘int execute_test_case(char*)’:
executeTestCase.cpp:112: error: ‘mount’ was not declared in this scope
make: *** [executeTestCase.o] Error 1
executeTestCase.cpp:104: error: invalid conversion from ‘void*’ to
‘const char*’
/usr/include/unistd.h:910: error: too many arguments to function ‘int
chroot(const char*)’
executeTestCase.cpp:104: error: at this point in file
make: *** [executeTestCase.o] Error 1
Subrata, can you confirm?
Ps: patch attached for file
"ltp-full-20071231/testcases/ballista/ballista/compile/bparser.cpp"
previous one was not complete.
Thanks,
--
Patrick Kirsch - Quality Assurance Department
SUSE Linux Products GmbH GF: Markus Rex, HRB 16746 (AG Nuernberg)
diff -pur ltp-full-20071231/testcases/ballista/ballista/compile/bparser.cpp ltp-full-20071231_patched/testcases/ballista/ballista/compile/bparser.cpp
--- ltp-full-20071231/testcases/ballista/ballista/compile/bparser.cpp 2008-01-01 06:45:00.000000000 -0500
+++ ltp-full-20071231_patched/testcases/ballista/ballista/compile/bparser.cpp 2008-01-22 11:32:43.000000000 -0500
@@ -17,18 +17,27 @@
*/
#include <ctype.h>
-#include <iostream.h>
-#include <fstream.h>
+#include <iostream>
+#include <fstream>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
-#include <vector.h>
+//#include <vector.h>
+#include <vector>
#include <unistd.h>
#include "tokens.h"
#include "butil.h"
#define MYMAP map<int, translationEntry,less<int>>
#define MAXLIST 10
+using std::endl;
+using std::cerr;
+using std::cout;
+using std::cin;
+using std::ios;
+using std::vector;
+using std::ofstream;
+using std::ostream;
vector<int> parseStack;
@@ -1064,7 +1073,7 @@ void buildH()
h1<<"#ifndef "<<obNamebak<<"_H"<<endl;
h1<<"#define "<<obNamebak<<"_H"<<endl;
h1<<"#include <errno.h>"<<endl;
- h1<<"#include <iostream.h>"<<endl;
+ h1<<"#include <iostream>"<<endl;
h1<<"#include <stdio.h>"<<endl;
h1<<"#include <stdlib.h>"<<endl;
h1<<"#include <stream.h>"<<endl;
@@ -1216,7 +1225,7 @@ void buildCPP()
cf<<"//--------------------------------------------------------------------"
<<endl<<endl;
cf<<"#include <errno.h>"<<endl;
- cf<<"#include <iostream.h>"<<endl;
+ cf<<"#include <iostream>"<<endl;
cf<<"#include <stdio.h>"<<endl;
cf<<"#include <stdlib.h>"<<endl;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
