Various tests still have a hardcoded value for the quantile nines. Use
a value automatically calculated from the number of iterations.
Signed-off-by: Sebastien Dugue <[EMAIL PROTECTED]>
Cc: Darren Hart <[EMAIL PROTECTED]>
Cc: Tim Chavez <[EMAIL PROTECTED]>
Cc: Sripathi Kodi <[EMAIL PROTECTED]>
---
.../realtime/func/gtod_latency/gtod_latency.c | 3 +--
.../realtime/func/hrtimer-prio/hrtimer-prio.c | 5 +----
.../periodic_cpu_load/periodic_cpu_load_single.c | 2 +-
.../pthread_kill_latency/pthread_kill_latency.c | 3 +--
.../realtime/func/sched_latency/sched_latency.c | 1 -
5 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/testcases/realtime/func/gtod_latency/gtod_latency.c
b/testcases/realtime/func/gtod_latency/gtod_latency.c
index d0b78b3..9c62d76 100644
--- a/testcases/realtime/func/gtod_latency/gtod_latency.c
+++ b/testcases/realtime/func/gtod_latency/gtod_latency.c
@@ -59,7 +59,6 @@
#define ITERATIONS 1000000
#define HIST_BUCKETS 20
-#define QUANTILE_NINES 6
#define SCATTER_FILENAME 0
#define HIST_FILENAME 1
@@ -227,7 +226,7 @@ int main(int argc, char *argv[])
stats_container_init(&dat, ITERATIONS);
stats_container_init(&hist, HIST_BUCKETS);
- stats_quantiles_init(&quantiles, QUANTILE_NINES);
+ stats_quantiles_init(&quantiles, log10(ITERATIONS));
setup();
if (stats_cmdline(argc, argv) < 0) {
diff --git a/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
b/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
index 6397266..91c6759 100644
--- a/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
+++ b/testcases/realtime/func/hrtimer-prio/hrtimer-prio.c
@@ -51,7 +51,6 @@
#define DEF_MED_PRIO 60 // (softirqd-hrtimer,98]
#define DEF_ITERATIONS 10000
-#define DEF_QUANTILE_NINES 4
#define HIST_BUCKETS 100
#define DEF_BUSY_TIME 10 // Duration of busy work in milliseconds
#define DEF_SLEEP_TIME 10000 // Duration of nanosleep in nanoseconds
@@ -63,7 +62,6 @@ static int high_prio = DEF_MED_PRIO+1;
static int busy_time = DEF_BUSY_TIME;
static int iterations = DEF_ITERATIONS;
static unsigned long criteria = DEF_CRITERIA; // FIXME: make configurable
-static int quantile_nines = DEF_QUANTILE_NINES;
static int busy_threads;
static stats_container_t dat;
@@ -104,7 +102,6 @@ int parse_args(int c, char *v)
high_prio = med_prio+1;
break;
case 'i':
- // FIXME: if we change these we also have to calc
QUANTILE_NINES here
printf("Setting iterations disabled\n");
// iterations = atoi(v);
break;
@@ -188,7 +185,7 @@ int main(int argc, char *argv[])
stats_quantiles_t quantiles;
stats_container_init(&dat, iterations);
stats_container_init(&hist, HIST_BUCKETS);
- stats_quantiles_init(&quantiles, quantile_nines);
+ stats_quantiles_init(&quantiles, log10(iterations));
t_id = create_fifo_thread(timer_thread, NULL, high_prio);
if (t_id == -1) {
diff --git
a/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
b/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
index 640c9a3..c5bb3d5 100644
--- a/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
+++ b/testcases/realtime/func/periodic_cpu_load/periodic_cpu_load_single.c
@@ -102,7 +102,7 @@ int periodic_thread(nsec_t period, int iterations, int
loops)
stats_container_init(&dat, iterations);
stats_container_init(&hist, HIST_BUCKETS);
- stats_quantiles_init(&quantiles, 4);
+ stats_quantiles_init(&quantiles, log10(iterations));
asprintf(&samples_filename, "%s-samples", filename_prefix);
asprintf(&hist_filename, "%s-hist", filename_prefix);
diff --git
a/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
b/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
index 53667a7..96a261b 100644
--- a/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
+++ b/testcases/realtime/func/pthread_kill_latency/pthread_kill_latency.c
@@ -58,7 +58,6 @@
#define PRIO 89
#define ITERATIONS 10000
#define HIST_BUCKETS 100
-#define QUANTILE_NINES 4
#define THRESHOLD 20
#define SIGNALNUMBER SIGUSR1
@@ -126,7 +125,7 @@ void *signal_receiving_thread(void *arg)
stats_container_init(&dat, ITERATIONS);
stats_container_init(&hist, HIST_BUCKETS);
- stats_quantiles_init(&quantiles, QUANTILE_NINES);
+ stats_quantiles_init(&quantiles, log10(ITERATIONS));
debug(DBG_DEBUG, "Signal receiving thread running\n");
diff --git a/testcases/realtime/func/sched_latency/sched_latency.c
b/testcases/realtime/func/sched_latency/sched_latency.c
index f286688..b91f40b 100644
--- a/testcases/realtime/func/sched_latency/sched_latency.c
+++ b/testcases/realtime/func/sched_latency/sched_latency.c
@@ -59,7 +59,6 @@
#define DEF_LOAD_MS 1
#define PASS_US 100
#define HIST_BUCKETS 100
-#define QUANTILE_NINES 4
#define OVERHEAD 50000 // allow for 50 us of periodic overhead (context
switch, etc.)
nsec_t start;
--
1.5.4.rc2.84.gf85fd-dirty
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
