Hi Sudhanshu,
On Thu, 28 Feb 2008 18:47:17 +0530 sudhanshu <[EMAIL PROTECTED]> wrote:
> On Thursday 28 February 2008 17:09:50 Subrata Modak wrote:
> > On Thu, 2008-02-28 at 11:04 +0100, Sebastien Dugue wrote:
> > > Hi Subrata,
> > >
> > > On Thu, 28 Feb 2008 15:24:31 +0530 Subrata Modak
> <[EMAIL PROTECTED]> wrote:
> > > > Thanks Sebastien for the 5th round of RT Linux Test Cases
> > > > Cleanup(s)/Enhancement(s). I would prefer these patches merged in March
> > > > 2008, and subsequently will be released during March 2008 LTP release,
> > > > as, we have our release tomorrow for Feb 2008.
> > >
> > > No problem, there's no need to rush.
> > >
> > > However I have some concerns regarding a patch from Sudhanshu that went
> > > in on Feb 22nd that breaks some tests. What's your plan for resolving
> > > this issue?
> >
>
> Sebastian ,
> Breaking in compilation ? or while running tests ?
None of the above, but some tests were functionally broken which I fixed
(things such as calculating the quantiles before saving the samples),
others were optimized (such as moving all stats stuff outside the threads
functions, ...). Unfortunately your patches reverted those fixes.
It looks like your patches reverted what I did in the following files:
func/periodic_cpu_load/periodic_cpu_load.c
func/pi_perf/pi_perf.c
func/sched_football/sched_football.c
func/sched_latency/sched_latency.c
Have a look at the following threads (damn, sourceforge is sooo slow):
http://sourceforge.net/mailarchive/forum.php?thread_name=1200303624-3410-1-git-send-email-sebastien.dugue%40bull.net&forum_name=ltp-list
http://sourceforge.net/mailarchive/forum.php?thread_name=1202992653-10955-1-git-send-email-sebastien.dugue%40bull.net&forum_name=ltp-list
> I saw tests to be building fine.
Right, they were building fine before my patches
> Not sure what thing I missed out. I will look into latest cvs.
You want to have a look at what your patch changed for those 4 files.
>
> Primafacie, I din't see any of your patches missing in the tree.
>
>
> > Ok i see. I also saw a mail from you to Sudhanshu on this. Actually that
> > patch was commented on by Chirag, and, Sudhanshu made changes to it.
> > Finally Chirag acked the modified version.
> >
> > Sudhanshu,
> >
> > Can you please look into Sebesteinś concerns and address them through a
> > Patch or 2 ? Let us get them fixed accordingly. He is talking about this
> > mail thread:
> >
> > http://sourceforge.net/mailarchive/forum.php?thread_name=200802221444.35437
> >.sudh%40linux.vnet.ibm.com&forum_name=ltp-list,
> >
>
> Subrata ,
> I will look into the issue.
> I am off for next couple of days, Chirag has agreed to assist regarding this
> in the mean time.
Ah, then I can try to fix it as I know where to look, it might be faster.
As you want.
Sebastien.
>
> - sudhanshu
>
> > Regards--
> > Subrata
> >
> > > > Meanwhile, you will see more discussion(s) on these set of Patches from
> > > > Dino/Chirag/Darren, before it is finally acked and merged into LTP.
> > > > Thanks once again for these Patches.
> > >
> > > Thanks,
> > >
> > > Sébastien.
>
>
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
