Subrata Modak wrote:
> On Fri, 2008-02-29 at 13:44 +0900, Atsushi Tsuji wrote:
>> Hi,
>>
>> I ran the latest LTP(ltp-20080131) on SLES10SP1 and found a failure on
>> the syslog testcases because of getting SIGSEGV at line 79 of
>> testcases/kernel/syscalls/syslog/syslogtst.c. it is caused by
>> accessing to the second argument when only one argument is provided
>> for syslogtst.
>>
>> The following patch fixes this problem by checking argc.
>>
>> Thanks,
>> Atsushi
>
> Thanks. But this does not apply cleanly on the latest CVS snapshot.
> Kindly resend by taking the diff over the present code in CVS.
>
> Regards--
> Subrata
>
>> Signed-off-by: Atsushi Tsuji <[EMAIL PROTECTED]>
>>
>> --- testcases/kernel/syscalls/syslog/syslogtst.c.orig 2008-02-26
>> 10:58:12.000000000 +0900
>> +++ testcases/kernel/syscalls/syslog/syslogtst.c 2008-02-27
>> 18:24:13.000000000 +0900
>> @@ -76,7 +76,7 @@ int main(int argc, char *argv[])
>>
>> else {
>> ch = atoi(argv[1]);
>> - ch1 = atoi(argv[2]);
>> + if(argc > 2) ch1 = atoi(argv[2]);
>> }
>>
>> /*
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> Ltp-list mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
Subrata,
Attached is a patch that applies to the current
tarball(ltp-full-20080229) It has the original fix from
Atsushi Tsuji. Minor comment indent cleanup.
Jeff
--- testcases/kernel/syscalls/syslog/syslogtst.c.orig
+++ testcases/kernel/syscalls/syslog/syslogtst.c
@@ -34,11 +34,11 @@
*/
-char *TCID="syslogtst"; /* Test program identifier. */
+char *TCID="syslogtst"; /* Test program identifier. */
int TST_TOTAL=1; /* Total number of test cases. */
extern int Tst_count; /* Test Case counter for tst_* routines */
-int exp_enos[]={0}; /* List must end with 0 */
+int exp_enos[]={0}; /* List must end with 0 */
void sig_handler(int signal);
@@ -76,7 +76,7 @@ int main(int argc, char *argv[])
else {
ch = atoi(argv[1]);
- ch1 = atoi(argv[2]);
+ if(argc > 2) ch1 = atoi(argv[2]);
}
/*
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
