On Sun, Mar 09, 2008 at 03:30:54AM -0500, Mike Frysinger wrote:
> On Sunday 09 March 2008, Robert Schwebel wrote:
> > Usually the cross compiler is set from the toplevel directory by
> > setting the CROSS_COMPILER variable. This makefile tries to
> > overwrite it (and even in two different ways - has this ever been
> > reviewed by anybody?), but wrong.
>
> nothing should be using $(CROSS_CFLAGS)

It should be possible to overwrite the integrated include paths with
-isystem for example (that's what we do in PTXdist); however, if it
isn't something for the mainline I suppose we find another way. The
variable is there and described in the toplevel Makefile, so it should
be possible to be used or removed.

> > -CC=gcc
> 
> OK
> 
> >  all: $(TARGETS)
> > -   gcc -o checkforlibcap gotlibcap.c
> > +   $(CC) $(CROSS_CFLAGS) $(CFLAGS) -o checkforlibcap gotlibcap.c
> 
> better to just use implicit rules ... the hardcoded rule here does not 
> support 
> LD related variables

Right.

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to