The last 5 patches or so I have seen this morning have contained proper
Signed-off-by's, but I have not seen any Acked-by: (or second Signed-off-by)
and
none of them have contained a description describing what the patch does or why
it was needed. This type of information is critical to have in the commit logs
when doing regression testing, and to prevent unknowingly undoing intentional
changes in later updates. Please take care to fully document patches.
--
Darren Hart
Subrata Modak wrote:
> Gilles Carry wrote:
>> Signed-off-by: Gilles Carry <[EMAIL PROTECTED]>
>> Cc: Darren Hart <[EMAIL PROTECTED]>
>> Cc: Tim Chavez <[EMAIL PROTECTED]>
>> ---
>> testcases/realtime/func/matrix_mult/matrix_mult.c | 46
>> ++++++++++----------
>> 1 files changed, 23 insertions(+), 23 deletions(-)
>>
>>
> Applied. Thanks.
>
> Regards--
> Subrata
>> diff --git a/testcases/realtime/func/matrix_mult/matrix_mult.c
>> b/testcases/realtime/func/matrix_mult/matrix_mult.c
>> index 1e66e34..1a9ce80 100644
>> --- a/testcases/realtime/func/matrix_mult/matrix_mult.c
>> +++ b/testcases/realtime/func/matrix_mult/matrix_mult.c
>> @@ -58,7 +58,7 @@ static int ops;
>>
>> void usage(void)
>> {
>> - rt_help();
>> + rt_help();
>> printf("matrix_mult specific options:\n");
>> printf(" -j enable jvmsim\n");
>> printf(" -l# #: number of multiplications per
>> iteration per cpu (load)\n");
>> @@ -66,22 +66,22 @@ void usage(void)
>>
>> int parse_args(int c, char *v)
>> {
>> - int handled = 1;
>> - switch (c) {
>> - case 'j':
>> - run_jvmsim = 1;
>> - break;
>> - case 'l':
>> - ops_multiplier = atoi(v);
>> - break;
>> - case 'h':
>> - usage();
>> - exit(0);
>> - default:
>> - handled = 0;
>> - break;
>> - }
>> - return handled;
>> + int handled = 1;
>> + switch (c) {
>> + case 'j':
>> + run_jvmsim = 1;
>> + break;
>> + case 'l':
>> + ops_multiplier = atoi(v);
>> + break;
>> + case 'h':
>> + usage();
>> + exit(0);
>> + default:
>> + handled = 0;
>> + break;
>> + }
>> + return handled;
>> }
>>
>> void matrix_init(float A[MATRIX_SIZE][MATRIX_SIZE], float
>> B[MATRIX_SIZE][MATRIX_SIZE])
>> @@ -123,7 +123,7 @@ void *matrixmult_thread(void *thread)
>> matrix_mult();
>> }
>>
>> - return NULL;
>> + return NULL;
>> }
>>
>> int main(int argc, char *argv[])
>> @@ -147,7 +147,7 @@ int main(int argc, char *argv[])
>> printf("Matrix Multiplication (SMP Performance)\n");
>> printf("---------------------------------------\n\n");
>> printf("Running %d iterations\n", ITERATIONS);
>> - printf("Matrix Dimensions: %dx%d\n", MATRIX_SIZE, MATRIX_SIZE);
>> + printf("Matrix Dimensions: %dx%d\n", MATRIX_SIZE, MATRIX_SIZE);
>> printf("Calculations per iteration: %d\n", ops);
>> printf("Number of CPUs: %u\n", numcpus);
>>
>> @@ -194,9 +194,9 @@ int main(int argc, char *argv[])
>> stats_hist(&shist, &sdat);
>>
>> stats_container_save("sequential", "Matrix Multiplication
>> Sequential Execution Runtime Scatter Plot",
>> - "Iteration", "Runtime (us)", &sdat, "points");
>> + "Iteration", "Runtime (us)", &sdat, "points");
>> stats_container_save("sequential_hist", "Matrix Multiplicatoin
>> Sequential Execution Runtime Histogram",
>> - "Runtime (us)", "Samples", &shist, "steps");
>> + "Runtime (us)", "Samples", &shist, "steps");
>>
>> // run matrix mult operation concurrently
>> printf("\nConcurrent (%dx):\n", numcpus);
>> @@ -237,9 +237,9 @@ int main(int argc, char *argv[])
>> stats_hist(&chist, &cdat);
>>
>> stats_container_save("concurrent", "Matrix Multiplication
>> Concurrent Execution Runtime Scatter Plot",
>> - "Iteration", "Runtime (us)", &cdat, "points");
>> + "Iteration", "Runtime (us)", &cdat, "points");
>> stats_container_save("concurrent_hist", "Matrix Multiplication
>> Concurrent Execution Runtime Histogram",
>> - "Iteration", "Runtime (us)", &chist, "steps");
>> + "Iteration", "Runtime (us)", &chist, "steps");
>>
>> printf("\nSeq/Conc Ratios:\n");
>> printf("Min: %.4f\n", (float)smin/cmin);
>>
>
>
--
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
