Hi All,

This is the vmsplice patch after updating with Mike's suggestion.

(See attached file: vmsplice.patch)

Thanks,
Vinay Sridhar


                                                                           
             Mike Frysinger                                                
             <[EMAIL PROTECTED]                                             
             g>                                                         To 
                                       [email protected]      
             03/29/2008 08:58                                           cc 
             AM                        Sridhar Vinay/India/[EMAIL PROTECTED],   
   
                                       Supriya Kannery/India/[EMAIL PROTECTED]  
   
                                                                   Subject 
                                       Re: [LTP]  Patch for vmsplice()     
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




On Thursday 27 March 2008, Sridhar Vinay wrote:
> The vmsplice01 testcase in LTP failed when run over machines with NFS
> mount. However after I examined the test case I found that the testcase
> performs vmsplice() and splice() system calls and it was only splice()
that
> caused the failure. After discussing with Subrata, we had decided that
the
> fact that vmsplice() succeeds must be displayed before checking if the
> testcase is running over NFS and exiting. Hence I have prepared a patch
> with the above details taken care of. Please review the below patch.

the idea of separating the display is OK, but using printf() is wrong.  we
have standard tst functions you should be using.
-mike
(See attached file: signature.asc)

Attachment: vmsplice.patch
Description: Binary data

Attachment: signature.asc
Description: Binary data

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to