Hi Subrata, I merged the two patches based on the lastest LTP CVS. Please check it again.
(See attached file: fix_segmentation_fault_in_pan.patch)
Best regards!
Jin Bing Guo 郭晋兵
-------------------------------------
"To be professional ..."
-- A killer said.
Subrata Modak
<[EMAIL PROTECTED]
et.ibm.com> To
Jin Bing Guo/China/[EMAIL PROTECTED]
05/19/2008 03:12 cc
PM [email protected],
Xiao Yan
Ding/China/Contr/[EMAIL PROTECTED], Yan
BJ
Please respond to Li/China/[EMAIL PROTECTED], Wen Bin
[EMAIL PROTECTED] Pan/China/[EMAIL PROTECTED]
t.ibm.com Subject
Re: [LTP] [patch 2/2] Fix
segmentation fault in pan/pan.c
with option "-p"
Hi Jin,
Thanks for those patches which fixes the PAN issue(s). But i tried to
apply those patches:
1) [LTP] [patch 1/1] Fix segmentation fault in
2) [LTP] [patch 2/2] Fix segmentation fault in pan/pan.c with option
"-p",
There seems to be some issues in applying them. I get some HUNK
Failures:
patching file pan/pan.c
Hunk #1 succeeded at 321 with fuzz 2.
patching file pan/pan.c
Hunk #1 FAILED at 321.
Hunk #2 FAILED at 1020.
2 out of 2 hunks FAILED -- saving rejects to file pan/pan.c.rej
Can you please resend me these 2 patches as a combined patch, and over
the latest LTP CVS. Sorry for bothering you for resending.
Regards--
Subrata
On Sat, 2008-05-17 at 18:09 +0800, Jin Bing Guo wrote:
> Hi,
> To execute pan/pan with option "-p" will occurs Segmentation fault.
>
> Here is the example,
> ----------------------------------------
> [EMAIL PROTECTED]:~/ltp/ltp$ pan.orig/pan -n ex1 echo hello -p
> hello
> <<<test_start>>>
> tag=cmdln stime=1211018279
> cmdline="echo hello "
> contacts=""
> analysis=exit
> initiation_status="ok"
> <<<test_output>>>
> incrementing stop
> <<<execution_status>>>
> duration=0 termination_type=exited termination_id=0 corefile=no
> cutime=0 cstime=0
> <<<test_end>>>
> Segmentation fault
> --------------------------------------
> The reason is that it not appends the "-l" option to pan to open the
> "logfile" for writing log.
> Just add a condition judgement to fix it.
>
> Signed-off-by: Jin Bing Guo <[EMAIL PROTECTED]>
> --------
> diff -ruNp pan.orig/pan.c pan/pan.c
> --- pan.orig/pan.c 2008-05-17 17:47:30.000000000 +0800
> +++ pan/pan.c 2008-05-17 17:54:01.000000000 +0800
> @@ -577,7 +577,7 @@ main(int argc, char **argv)
> ++exit_stat;
> }
> fclose(zoofile);
> - if (fmt_print)
> + if (logfile && fmt_print)
> {
> if (uname(&unamebuf) == -1)
> fprintf(stderr, "ERROR: uname(): %s\n", strerror(errno));
>
>
> Best regards!
>
> Jin Bing Guo 郭晋兵
> -------------------------------------
> "To be professional ..."
> -- A killer said.
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
<<inline: graycol.gif>>
<<inline: pic00867.gif>>
<<inline: ecblank.gif>>
fix_segmentation_fault_in_pan.patch
Description: Binary data
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
