Hi Veerendra,
I am not sure exactly what changes in "r/o bind mounts" went in 2.6.26-rc6.
As you are involved in the "r/o bind mounts namespace" test cases
development, i thought i would just ping you for this. It would be great if
these kernel changes are also reflected in your test cases iterenary.
Regards--
Subrata
On Fri, Jun 20, 2008 at 7:47 PM, Dave Hansen <[EMAIL PROTECTED]>
wrote:
> On Fri, 2008-06-20 at 12:16 +0200, Jens Rottmann wrote:
> >
> > I noticed the following change in the error behaviour when attempting
> > to delete nonexisting files/dirs from R/O-mounted directories:
> >
> > Linux 2.6.25.7:
> > rm /RO_mounted_path/nonexisting_file
> > ==> "No such file or directory"
> >
> > Linux 2.6.26-rc6-git6:
> > rm /RO_mounted_path/nonexisting_file
> > ==> "Read-only file system"
>
> We looked at this way back in the beginning when I started to work on
> the patches. It was decided that the error codes weren't horribly
> important. We did have a case a bit ago where it really mattered, and
> Al fixed that up.
>
> I know this changed behavior a bit, but userspace can surely work around
> it with read-only operations (stat) when it is really important to get
> the error to the user just right.
>
> > @@ -2371,8 +2373,10 @@ static long do_unlinkat(int dfd, const c
> > if (inode)
> > atomic_inc(&inode->i_count);
> > error = mnt_want_write(nd.path.mnt);
> > - if (error)
> > + if (error) {
> > + error = vfs_unlink(nd.path.dentry->d_inode,
> dentry);
> > goto exit2;
> > + }
> > error = vfs_unlink(nd.path.dentry->d_inode, dentry);
> > mnt_drop_write(nd.path.mnt);
>
> On a r/w fs where this is being performed on a r/o bind mount, this will
> let you unlink files. I think that's bad. :)
>
> -- Dave
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Regards & Thanks--
Subrata
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
