On Tue, 2008-07-22 at 09:03 +0800, Shi Weihua wrote: > Subrata Modak wrote: > > On Fri, 2008-07-18 at 16:39 +0900, Masatake YAMATO wrote: > >> Hi, > >> > >> I got following compile error: > >> > >> make[4]: Entering directory > >> `/home/yamato/var/hjcjk/ltp/testcases/kernel/sched/cfs-scheduler' > >> cc -Wall -I../../../../include -Wall hackbench.c > >> -L../../../../lib -lltp -lpthread -o hackbench > >> hackbench.c: In function ‘create_worker’: > >> hackbench.c:203: error: ‘PTHREAD_STACK_MIN’ undeclared (first use in > >> this function) > >> hackbench.c:203: error: (Each undeclared identifier is reported only > >> once > >> hackbench.c:203: error: for each function it appears in.) > >> hackbench.c: In function ‘main’: > >> hackbench.c:348: warning: control reaches end of non-void function > >> make[4]: *** [hackbench] Error 1 > >> make[4]: Leaving directory > >> `/home/yamato/var/hjcjk/ltp/testcases/kernel/sched/cfs-scheduler' > >> > >> My platform is: > >> > >> [yamato ltp]$ uname -a > >> Linux beach 2.6.25.9-76.fc9.x86_64 #1 SMP Fri Jun 27 15:58:30 EDT 2008 > >> x86_64 x86_64 x86_64 GNU/Linux > >> [yamato ltp]$ cat /etc/redhat-release > >> Fedora release 9 (Sulphur) > >> [yamato ltp]$ rpm -qi glibc > >> Name : glibc Relocations: (not > >> relocatable) > >> Version : 2.8 Vendor: Fedora Project > >> Release : 3 Build Date: Mon 05 May 2008 > >> 09:37:30 PM JST > >> Install Date: Sat 05 Jul 2008 04:25:07 AM JST Build Host: > >> xenbuilder4.fedora.phx.redhat.com > >> Group : System Environment/Libraries Source RPM: > >> glibc-2.8-3.src.rpm > >> Size : 12475571 License: LGPLv2+ and > >> LGPLv2+ with exceptions and GPLv2+ > >> Signature : DSA/SHA1, Tue 06 May 2008 12:27:30 AM JST, Key ID > >> b44269d04f2a6fd2 > >> Packager : Fedora Project > >> URL : http://sources.redhat.com/glibc/ > >> Summary : The GNU libc libraries > >> > >> > >> With the following patch, the compiler error is gone. > >> > >> Signed-off-by: Masatake YAMATO <[EMAIL PROTECTED]> > > > > Thanks Yamato. > > > > Can you also look in to the aspect, when the present form of hackbecnh > > test cases fail, when we run it on both Process and thread mode, owning > > to opening up of maximum no. of files allowed. This also needs to be > > fixed. > > In fact, the case "hackbench02 hackbench 150 thread 1000" failed when i tested > the latest ltp. the following error message occured: > -------------------- > Creating fdpair (error: Too many open files) > -------------------- > > The default open files is 1024 (ulimit -n), but hackbench does not close > these > all opened files in group() when thread mode (process_mode=0). > > I think we should to limit the num_groups's value. 20 is a suitable value, it > works > well on my ia64 and i386 machine. > what do you think?
Though this solves the problem temporarily, but i would got for it for the time being. But we might need to fix the hackbench code instead by closing those FDś in appropriate places. Patch merged. Regards-- Subrata > > Signed-off-by: Shi Weihua <[EMAIL PROTECTED]> > --- > diff -urpN ltp-full-20080630.orig/runtest/sched > ltp-full-20080630/runtest/sched > --- ltp-full-20080630.orig/runtest/sched 2008-06-29 04:19:01.000000000 > +0800 > +++ ltp-full-20080630/runtest/sched 2008-07-21 09:48:02.000000000 +0800 > @@ -7,4 +7,4 @@ time-schedule01 time-schedule > trace_sched01 trace_sched -c 1 > > hackbench01 hackbench 150 process 1000 > -hackbench02 hackbench 150 thread 1000 > +hackbench02 hackbench 20 thread 1000 > > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
