On Fri, 2008-08-01 at 12:56 +0800, Li Zefan wrote:
> CC: Andrea Righi <[EMAIL PROTECTED]>
> 
> Shi Weihua wrote:
> > following compile error message occured on ia64 box.
> > 
> > ------------------
> > iobw.c: In function ‘thread’:
> > iobw.c:87: error: ‘PAGE_SIZE’ undeclared (first use in this function)
> > iobw.c:87: error: (Each undeclared identifier is reported only once
> > iobw.c:87: error: for each function it appears in.)
> > iobw.c: In function ‘main’:
> > iobw.c:228: error: ‘PAGE_SIZE’ undeclared (first use in this function)
> > make[4]: *** [iobw] Error 1
> > make[4]: Leaving directory 
> > `/home/tester/work-b/testnow/ltp-full-20080731/testcases/kernel/controlle
> > make[3]: *** [all] Error 2
> > ------------------
> > 
> > Signed-off-by: Shi Weihua <[EMAIL PROTECTED]>
> > ---
> > --- ltp-full-20080731.orig/testcases/kernel/controllers/io-throttle/iobw.c  
> > 2008-07-15 02:16:07.000000000 +0900
> > +++ ltp-full-20080731/testcases/kernel/controllers/io-throttle/iobw.c       
> > 2008-08-01 12:34:51.000000000 +0900
> > @@ -36,6 +36,8 @@
> >  #include <sys/wait.h>
> >  #include <asm/page.h>
> >  
> > +#define PAGE_SIZE getpagesize()
> > +
> 
> You should get a gcc warning on x86: "PAGE_SIZE" redefined
> 
> We can avoid the warning:
> #ifndef PAGE_SIZE
> #define PAGE_SIZE getpagesize()
> #endif

Thanks. I liked this. The same has been updated.

Regards--
Subrata

> 
> But normally upper-case macros means constants, but the above macro
> is not a constant.
> 
> >  #define ALIGN(x,a)         __ALIGN_MASK(x,(typeof(x))(a)-1)
> >  #define __ALIGN_MASK(x,mask)       (((x)+(mask))&~(mask))
> >  #define KB(x)                      ((x) >> 10)
> > 
> > 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to