On Mon, 2008-08-11 at 15:14 +0530, B. N. Poornima wrote: > Subrata Modak wrote: > > Poornima, > > > > Please resend it as a patch containing the source code/directories, > > Makefile(s), scripts(if any) and entry inside runtest/syscalls, all > > together integrated. I can test then. > > > > Regards-- > > Subrata > > > > On Thu, 2008-07-31 at 18:30 +0530, B. N. Poornima wrote: > > > >> Hi, > >> I have developed test cases for sync_file_range() system call which will > >> do the basic sanity (error) checking for the system call. These tests > >> have to be run on 2.6.17 kernel and above. > >> The test cases have been currently tested only on x86 and x86_64 > >> architecture. > >> Also, I have hard coded the system call number in the test case for > >> review purposes and will be later on moving it to > >> linux_syscall_numbers.h file in the LTP framework. > >> Please review the test cases and provide your comments so that I can > >> improve the same. > >> > >> Thanks, > >> Poornima. > >> > > > > > Subrata, > Re-sending the test cases as a patch. Please test and provide your > feedback. Thanks!
Thanks Poornima for resending the Patch once again. I have tested it and please see the results i obtained: 1) # uname -a Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:43:57 EDT 2008 x86_64 x86_64 x86_64 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # testcases/bin/sync_file_range01 sync_file_range01 1 PASS : expected failure - errno = 9 : Bad file descriptor sync_file_range01 2 PASS : expected failure - errno = 29 : Illegal seek sync_file_range01 3 PASS : expected failure - errno = 22 : Invalid argument sync_file_range01 4 PASS : expected failure - errno = 22 : Invalid argument sync_file_range01 5 PASS : expected failure - errno = 22 : Invalid argument 2) # uname -a Linux 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:56:44 EST 2007 x86_64 x86_64 x86_64 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # testcases/bin/sync_file_range01 sync_file_range01 0 WARN : System doesn't support execution of the test 2) # uname -a Linux 2.6.9-22.EL #1 SMP Mon Sep 19 17:52:20 EDT 2005 ppc64 ppc64 ppc64 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # testcases/bin/sync_file_range01 sync_file_range01 0 WARN : System doesn't support execution of the test 3) # uname -a Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:48:59 EDT 2008 ppc64 ppc64 ppc64 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # ./testcases/bin/sync_file_range01 sync_file_range01 0 WARN : System doesn't support execution of the test 4) # uname -a Linux 2.6.23.13 #1 SMP Wed Jan 9 18:14:28 PST 2008 ia64 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # ./testcases/bin/sync_file_range01 sync_file_range01 1 PASS : expected failure - errno = 9 : Bad file descriptor sync_file_range01 2 PASS : expected failure - errno = 29 : Illegal seek sync_file_range01 3 PASS : expected failure - errno = 22 : Invalid argument sync_file_range01 4 PASS : expected failure - errno = 22 : Invalid argument sync_file_range01 5 PASS : expected failure - errno = 22 : Invalid argument 5) # uname -a Linux 2.6.9-22.ELsmp #1 SMP Mon Sep 19 18:32:14 EDT 2005 i686 i686 i386 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # ./testcases/bin/sync_file_range01 sync_file_range01 0 WARN : System doesn't support execution of the test 6) # uname -a Linux 2.6.18-91.el5PAE #1 SMP Tue Apr 22 17:58:37 EDT 2008 i686 i686 i386 GNU/Linux BUILD=Pass, INSTALL=Pass, RUN=Pass, # ./testcases/bin/sync_file_range01 sync_file_range01 1 PASS : expected failure - errno = 9 : Bad file descriptor sync_file_range01 2 PASS : expected failure - errno = 29 : Illegal seek sync_file_range01 3 PASS : expected failure - errno = 22 : Invalid argument sync_file_range01 4 PASS : expected failure - errno = 22 : Invalid argument sync_file_range01 5 PASS : expected failure - errno = 22 : Invalid argument MY OBSERVATIONS: ======================================================= 1) The Build/Install issues on various architectures and under varying kernel versions has been taken care of properly, 2) The running of test cases are also pretty fine. However there are issues which needs to be addressed: 1) As you mentioned that the test will run with kernel >= 2.6.17. This seems satisfied with all combinations i tried, except item no. 3 above, where the kernel is 2.6.18-91.el5 for ppc64. Is it that the support for this system call has to be explicitly done during kernel build, or it will automatically take care ? 2) When running below kernel 2.6.17, it should throw the following message: sync_file_range01 0 CONF : System doesn't support execution of the test instead of: sync_file_range01 0 WARN : System doesn't support execution of the test, And the test should return PASS/0 in this case (which will be taken care of by the tst_* functions in such a case). Please see Paul Larson´s article on this: http://ltp.sourceforge.net/documentation/technical_papers/ltp.pdf (Pages 4-6) If this issue is addressed, i can include this new test with immediate effect. Thanks for putting effort for writing this test. Regards-- Subrata > > Regards, > Poornima. > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
