On Mon, 2008-08-25 at 16:32 +0530, Rishikesh K. Rajak wrote: > Hi All, > > When we execute `./growfiles -h` command then it gives the result as: > growfiles 1 PASS : Test passed > Which is just confusing the user that some testcase has been executed, > whether it just ran the help/usage command. So here is the small patch > for fixing this issue.
Yes, it solves the issue. Thanks for pointing that out. This patch is merged. Post Patching the line: growfiles 1 PASS : Test passed does not show up. But there are other simple exit()s in that growfiles.c. Would you like to work on them too and send a patch replacing them with tst_exit() like this one ? Also, when you send your next patch, kindly adhere to the following guidelines: 1) Include the following in your mail: Signed-Off-By: "Rishikesh K. Rajak" <[EMAIL PROTECTED]> 2) Take the diff -uprN from the LTP-Root, like: --- ltp/testcases/kernel/fs/doio.orig/growfiles.c +++ ltp/testcases/kernel/fs/doio/growfiles.c instead of: --- doio.orig/growfiles.c +++ doio.orig/growfiles.c Thank you very much for submitting this patch. Regards-- Subrata > --- > Index: doio/growfiles.c > =================================================================== > --- doio.orig/growfiles.c 2008-08-25 09:57:54.000000000 +0530 > +++ doio/growfiles.c 2008-08-25 09:58:13.000000000 +0530 > @@ -423,7 +423,7 @@ > > case 'h' : > help(); > - exit(0); > + tst_exit(); > > case 'B': > switch (sscanf(optarg, "%i%c", > > > > Thanks > Rishi > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
