On Mon, 2008-09-01 at 23:30 +0200, Daniel Gollub wrote: > Hi, > > while packaging LTP 20080831, package validation with rpmlinit complains about > following scripts which have not the excutable bit set: > > ./testcases/kernel/security/mmc_security/ask_password.sh > ./testcases/kernel/security/mmc_security/change_password.sh > ./testcases/kernel/security/mmc_security/assign_password.sh > ./testcases/kernel/security/mmc_security/remove_password.sh > ./testcases/kernel/security/mmc_security/force_erase.sh > ./tools/netpipe-2.4/netpipe.sh > > (Note: i didn't checked if this got changed recently/is a regression, just > going > through the packaging warnings and reporting them) > > The mmc_security executable flags warnings i guess are minor issue, since it's > not part of any default testrun profile - right? > > netpipe.sh permission got changed by ./chmod.sh in the Makefile. This chmod.sh > script checks if the current user is "root", if not it fails and will not add > the executable bit by calling "chmod 755". I guess the check for user "root" > is > an uninteded sanity check to set suid bit, but not for "chmod 755". > > Not quite sure if suid-bit was acutally inteded or not, but for just setting > the executable bit a simple call of "chmod 755" in Makefile is enough and > ./tools/netpipe-2.4/chmod.sh should be removed. > > Attachted patch replaces chmod.sh by chmod 755 call. Instead of applying the > patch i recommend to just drop chmod.sh and add the excutable bit of the file > in SCM. > > best regards, > Daniel > > --- > > Set executable flag for netpipe.sh without chmod.sh which just performs an > santiy check if the user is root to run chmod 755, which doesn't require > root priviliges. >
This is a problem with CVS. Once you initially add some script without execute permission, that´s it, the whole life this will trouble you. And then there is not where you can solve the problem other than in Makefile(s). > Signed-off-by: Daniel Gollub <[EMAIL PROTECTED]> Thanks. Merged. Regards-- Subrata > > --- > > diff --git a/tools/netpipe-2.4/Makefile b/tools/netpipe-2.4/Makefile > index 9353bf7..8a8df37 100644 > --- a/tools/netpipe-2.4/Makefile > +++ b/tools/netpipe-2.4/Makefile > @@ -27,7 +27,7 @@ EXTRA_LIBS = $(LDFLAGS) > all: $(TARGETS) > > install: > - @/bin/sh ./chmod.sh netpipe.sh > + @/bin/sh chmod 755 netpipe.sh > @ln -f $(TARGETS) netpipe.sh ../../testcases/bin/ > # > # This section of the Makefile is for compiling the binaries > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
