Subrata Modak writes:
> And here goes the Patch. Paul, you can propose more modification to this
> if you wish to:
Looks OK as far as I can see, except that I wonder why you check for
being root:
> + /* Check whether we are root*/
> + if (geteuid() != 0) {
> + tst_brkm(TBROK, tst_exit, "Test must be run as root");
> + }
since there is no restriction by the kernel on which processes can use
this system call. A process can't do anything to any other process
using this system call, so there's no reason to restrict it.
> + tst_resm(TPASS, "switch() syscall tests passed");
Also you might like to call it "endian_switch()" rather than just
"switch()".
Paul.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
