Hi,

I'd like to add more comments.

About TST_SETGID_COMPAT_16 and TST_SETGROUPS_COMPAT_16 make file options
I wrote:

> If it is not so popular, compat_16 should be turned on by default.

If an environments has a trouble about setgid16 I guess it also has 
troubles about all foo16 system calls. If my guessing is correct, the
options can be unified to TST_COMPAT_16. So the make invocation becomes
like:

        make TST_COMPAT_16=yes

I'll add more foo16 test cases to LTP, so adding TST_FOO_COMPAT_16 option
too them may bore me. How do you think?


If you agree with me, I'd like to suggest you to modify
ltp/testcases/kernel/syscalls/utils/compat_16.mk like:

From:
        TARGETS_16 = $(patsubst %.c,%_16,$(SRCS))
        TARGETS  +=  $(TARGETS_16)


To:
        TARGETS_16 = $(patsubst %.c,%_16,$(SRCS))
    if XXX
        TARGETS  +=  $(TARGETS_16)
    endif


Regards,
Masatake YAMATO

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to