Vijay, thank you for reviweing.
> > In the Makefile of signalfd, -DHAS_SIGNALFD_H is added to CFLAGS if
> > sys/signalfd.h exists. If it doesn't exist, following code is compiled
> > as signalfd01 test case:
> > #include <stdio.h>
> > int
> > main(int argc, char** argv)
> > {
> > printf("%s 0 CONF: System doesn't support execution of the test\n",
> > "signalfd01");
> > return 0;
> > }
>
> You could use tst_resm() here. In case somebody decides to change
> the test output format later, he can do it in one function
> tst_resm().
Very important input.
Test cases for io_* use echo commands when libaio.h cannot be found.
I should also fix these.
> > Please review the code, and give me feed back.
> > If they are acceptable, I'll modify other test cases to use cond.mk.
> > If submitting a patch for reviewing in MIME attachment is inconvenient, let
> > me know.
> > I'll paste my code to my mail.
>
> An inlined patch would be very convenient.
>
O.K. I'll send my code in separated mail.
Masatake
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
