Hi YAMATO,

I complete agree with you to take over the two patches.
Since you ported these testcases  from Crackerjack, it's better you improve
the cases in a large scale. I just tested some of them and returned my
feedback.

Best regards!

Jin Bing Guo  郭晋兵

Linux for System p Test
IBM China Systems & Technology Laboratory in Beijing
Tel:   +86-10-82454439
Email: [EMAIL PROTECTED]
-------------------------------------
"Do today what others won't so tomorrow you do what other's can't"




                                                                       
             Masatake YAMATO                                           
             <[EMAIL PROTECTED]                                         
             m>                                                         To
                                       Jin Bing Guo/China/[EMAIL PROTECTED]    
             09/29/2008 10:35                                           cc
             AM                        [email protected]  
                                                                   Subject
                                       Re: [LTP] [PATCH 2/3] Fix the make
                                       install error in modify_ldt on  
                                       ppc64                           
                                                                       
                                                                       
                                                                       
                                                                       
                                                                       
                                                                       



e
Hi,

> On ppc64, the modify_ldt cases would not been compiled. So it should be
> return
> the message:"System doesn't support execution of the test" instead of an
> error message.


Using tst_resm C function is better than using echo command.

See the comment by Vijay Kumar.
http://sourceforge.net/mailarchive/message.php?msg_name=48C67E2C.7030905%40bravegnu.org


I'm also working this area, If you are O.K., I'd like to take over your
patches:

   [LTP] [PATCH 1/3] Fix the make install error in io_* testcases
   [LTP] [PATCH 2/3] Fix the make install error in modify_ldt on ppc64

My intents are:

   1. Using check_header in cond.mk
   2. Using #ifdef/#endif and tst_resm C function instead of echo command
like:
      echo "${syscall}01 0 CONF : System doesn't support execution of the
test"
   3  Target test cases are:
      - signalfd
      - modify_ldt
      - io_*
      - eventfd
      - inotify

Regards,
Masatake YAMATO

<<inline: graycol.gif>>

<<inline: pic30924.gif>>

<<inline: ecblank.gif>>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to