Mike Frysinger escreveu:
> On Sunday 05 October 2008, Subrata Modak wrote:
>
>> On Thu, 2008-10-02 at 17:45 -0300, Elder Costa wrote:
>>
>>> Under Ubuntu several network stress tests fail due to the use of bash
>>> specific syntax that Ubuntu's sh (aka dash) does not support.
>>>
>>> I have managed to work around them by simply changing the headers of all
>>> the scripts from #!/bin/sh to #!/bin/bash.
>>>
>>> I would like to suggest this change as I think it will have no impact
>>> over other Linux distros.
>>>
>>> I am attaching a script instead of a patch as the latter would be too
>>> BIG for the task.
>>>
>>> Regards.
>>>
>>> Elder.
>>>
>>> Signed-Off-By: Elder Costa <[EMAIL PROTECTED]>
>>> plain text document attachment (patch_network_stress)
>>> #!/bin/sh
>>>
>>> if [ $# -ne 1 ]; then
>>> echo "Usage: $0 LTP_ROOT"
>>> exit 1
>>> fi
>>>
>>> STRESS_DIR="$1/testcases/network/stress"
>>> ls -ld ${STRESS_DIR} 1>/dev/null 2>/dev/null
>>> if [ $? -ne 0 ]; then
>>> echo "Invalid LTP_ROOT"
>>> exit 1
>>> fi
>>>
>>> cd ${STRESS_DIR}
>>>
>>> find . -type f | xargs sed -i s/'\/bin\/sh'/'\/bin\/bash'/
>>>
>> What do you think about this ?
>>
>
> blindly converting to /bin/bash is an awful idea. Ubuntu is also know to
> ship
> a broken shell. why dont we get examples of failures and then we can figure
> out whether it's Ubuntu being broken or there actually are bashisms in the
> scripts (which we would then fix).
>
> simply saying "the scripts have bashisms" is not nearly enough for me to
> actually check ... there's too many scripts and i have no idea what i'm
> looking for.
> -mike
>
Hello. I am not a shell script expert. So I cannot say if what I read in
some sites (e.g. https://wiki.ubuntu.com/DashAsBinSh) is accurate as far
as bashisms are concerned. But some examples in the network stress test
scripts that I have read are bashisms:
1- use of source instead of .
2- use of == for comparisons
3- uname -u (not sure if it is a bashism but dash does not support it).
I will run the test tomorrow without the changes and post the results.
Regards.
Elder.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
