> > > Nice work! I try to review some more... > > > > Thanks Cai for fixing all those warnings. Almost all are gone. Thanks > > Daniel for providing comments. This has been checked in. Can you please > > also look into the residual few below: > > > > make[3]: Entering directory > > `/SEPTEMBER_2008_RELEASE/ltp-full-20080930/testcases/ballista/ballista' > > g++ -Wno-deprecated -Wall -w -DB_SELFHOST callGen.cpp -o callGen > > /tmp/ccImvj9h.o: In function > > `__static_initialization_and_destruction_0(int, int)': > > callGen.cpp:(.text+0x53): warning: the use of `tempnam' is dangerous, > > better use `mkstemp' > > g++ -Wno-deprecated -Wall -w -DB_SELFHOST callGen_standAlone.cpp -o > > callGen_standAlone > > /tmp/cc2f4HI9.o: In function > > `__static_initialization_and_destruction_0(int, int)': > > callGen_standAlone.cpp:(.text+0x53): warning: the use of `tempnam' is > > dangerous, better use `mkstemp' > > g++ -Wno-deprecated -Wall -w -DB_SELFHOST genCodeCreator.cpp -o > > genCodeCreator > > > > I have looked at those before, but it looks like the best I can do is to > leave as it is. It is > painful to rewrite all tempnam() to mkstemp(). File operations with tempnam() > are done with file > name using C++'s iostream; while mkstemp() needs to deal with file > descriptors, and also there is > no easy to way to write a wrapper to map file descriptors to file names. In > addition, those > warnings are harmless here, as we probably don't need to care security holes > with tempnam() during > testing. >
Hmmm. That should be fine. Let us leave it there as it is. Regards-- Subrata > Cai Qian ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
