On Mon, 2008-10-20 at 13:34 +0200, Daniel Gollub wrote:
> plain text document attachment (setgroups_uninitialized_gid_list.diff)
> setgroups02(_16) is working with an uninitialized list, expect the first GID
> field. setgroups() and getgroups() additionally get called with the full
> length
> of the uninitialized list. The uninitialized values cause setgroups02_16 to
> fail:
>
> ===
> setgroups02_16 1 BROK : gid returned from getgroups is too large for
> testing setgroups32
> ===
>
> Since the uninitialized values could be greater then 0xffff.
>
>
> Signed-off-by: Daniel Gollub <[EMAIL PROTECTED]>
yes, it solves the issues for x86_64. Post patching:
# ./testcases/kernel/syscalls/setgroups/setgroups01_16
setgroups01_16 1 PASS : setgroups(65536, list) returned 0
# ./testcases/kernel/syscalls/setgroups/setgroups02_16
setgroups02_16 1 PASS : Functionality of setgroups(1, groups_list)
successful
# ./testcases/kernel/syscalls/setgroups/setgroups03_16
setgroups03_16 1 PASS : setgroups(65537) fails, Size is >
sysconf(_SC_NGROUPS_MAX), errno=22
setgroups03_16 2 PASS : setgroups(65536) fails, Permission denied,
not super-user, errno=1
# ./testcases/kernel/syscalls/setgroups/setgroups04_16
setgroups04_16 1 PASS : setgroups() fails with expected error
EFAULT errno:14
Thanks. Merged.
Regards--
Subrata
>
> ---
>
> Index: ltp-full-20081017/testcases/kernel/syscalls/setgroups/setgroups02.c
> ===================================================================
> --- ltp-full-20081017.orig/testcases/kernel/syscalls/setgroups/setgroups02.c
> +++ ltp-full-20081017/testcases/kernel/syscalls/setgroups/setgroups02.c
> @@ -91,7 +91,7 @@ main(int ac, char **av)
> {
> int lc,i; /* loop counters */
> char *msg; /* message returned from parse_opts */
> - int gidsetsize = NGROUPS; /* total groups */
> + int gidsetsize = 1; /* only one GID, the GID of TESTUSER */
> int PASS_FLAG = 0; /* used for checking group array */
>
> /* Parse standard options given to run the test. */
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
