Hi,

--- Vinay Sridhar <[EMAIL PROTECTED]> wrote:

> Hello,
> 
> The mc_cmds script under ltp network test returns "fail"
> when /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts is set to 1. This
> just means that this feature is disabled. Added a check to report this
> message and exit.
> 
> Thanks,
> Vinay
> 
> Vinay Sridhar,
> Linux Technology Centre,
> IBM ISTL,
> Bangalore, India
> 
> 
> 
> Signed-off by : Vinay Sridhar <[EMAIL PROTECTED]>
> 
> diff -Nuarp
> ltp-full-20080930.old/testcases/network/multicast/mc_cmds/mc_cmds
> ltp-full-20080930/testcases/network/multicast/mc_cmds/mc_cmds
> --- ltp-full-20080930.old/testcases/network/multicast/mc_cmds/mc_cmds
> 2008-09-30 18:06:50.000000000 +0530
> +++ ltp-full-20080930/testcases/network/multicast/mc_cmds/mc_cmds
> 2008-10-21 11:15:50.000000000 +0530
> @@ -124,6 +124,13 @@ for eth in $IFNAME
>      fi
>  # Added end
>  
> +   cat /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts | grep 1
> > /dev/null
> +   if [ $? -eq 0 ]
> +   then
> +       echo "Multicast disabled on this system"
> +       exit
> +   fi
> +

Could we set it to 0, do the test, and then restore it? Also, it is probably 
easier to read using
the following,

grep -q 1 /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts

Cai Qian 

>     # Do the ping tests: Execute ping 224.0.0.1 - Verify that the
> proper 
>     # number of responses are returned.
>  
> 
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to