On Wed, 2008-10-22 at 11:28 -0700, Malov, Vlad wrote:
> Again, the patch deals with _NR_fstatat64 and __NR_newfstatat stubs when
> builds the test. We do not really want to test stubs when a good
> definition is available.
> See attached patch file, copy here.
> Tested with _fstatat64 or __NR_newfstatat defined, not tested  when both
> stubbed.
> 
> 
> Signed-off by : Vlad Malov [EMAIL PROTECTED]

Thanks and Applies fine.

Regards--
Subrata

> 
> 
> 
> --- testcases/kernel/syscalls/fstatat/fstatat01.c.orig        2008-10-22
> 10:04:49.000000000 -0700
> +++ testcases/kernel/syscalls/fstatat/fstatat01.c     2008-10-22
> 10:05:12.000000000 -0700
> @@ -78,23 +78,31 @@ char *filenames[TEST_CASES];
>  int expected_errno[TEST_CASES] = { 0, 0, ENOTDIR, EBADF, EINVAL, 0 };
>  int flags[TEST_CASES] = { 0, 0, 0, 0, 9999, 0 };
>  
> -#ifdef __NR_fstatat64
> +#if (defined __NR_fstatat64) && (__NR_fstatat64 != 0)
>  struct stat64 statbuf;
>  #else
>  struct stat statbuf;
>  #endif
>  
> -#ifdef __NR_fstatat64
> +/* __NR_fstatat64 and __NR_fstatat64 if not defined are ALWAYS stubbed
> by
> + *  linux_syscall_numbers.h Need to check for 0 to avoid testing with
> stubs */
> +#if (defined __NR_fstatat64) && (__NR_fstatat64 != 0)
>  int myfstatat(int dirfd, const char *filename, struct stat64 *statbuf,
>             int flags)
>  {
>       return syscall(__NR_fstatat64, dirfd, filename, statbuf, flags);
>  }
> -#else
> +#elif (defined __NR_newfstatat) && (__NR_newfstatat != 0)
>  int myfstatat(int dirfd, const char *filename, struct stat *statbuf,
> int flags)
>  {
>       return syscall(__NR_newfstatat, dirfd, filename, statbuf,
> flags);
>  }
> +#else 
> +/* stub - will never run */
> +int myfstatat(int dirfd, const char *filename, struct stat *statbuf,
> int flags)
> +{
> +        return syscall(0, dirfd, filename, statbuf, flags);
> +}
>  #endif
>  
>  int main(int ac, char **av)
> @@ -111,6 +119,18 @@ int main(int ac, char **av)
>               exit(0);
>            }
>  
> +     /* report failure if run with stubs */
> +#ifdef __NR_fstatat64
> +        if(__NR_fstatat64 == 0)
> +#endif
> +#ifdef __NR_newfstatat 
> +        if(__NR_newfstatat == 0)
> +#endif
> +       {
> +          tst_resm(TFAIL, "fstatat() Failed, neither __NR_fstatat64 "
> +                          "no __NR_newfstatat is implemented ");
> +          exit(0);
> +       }
>  
>       /***************************************************************
>        * parse standard options
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________ Ltp-list mailing list 
> [email protected] 
> https://lists.sourceforge.net/lists/listinfo/ltp-list


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to