Hello,On Mon, 17 Nov 2008 12:19:13 +0100, Subrata Modak <[EMAIL PROTECTED]> wrote:
On Fri, 2008-11-14 at 12:40 -0500, Michael Kerrisk wrote:> Here's the latest version, for review-n-test enjoyment: I made a few small tweaks to the changelog: wording fixes, and para break fixes; other than that, changed the text to say that I rewrote (rather than updated) the test program. Please substitute it with the following.I just did a quick patch for your test to run on LTP. If you have no issue(s), can we add this to LTP ? LTP-list, Can you also enrich this patch ?
I have some nitpicks, in decreasing severity:First, the syscall, I believe, is not targeted at i386 and x86-64 only. Therefore, it is not wise to have these explicitly mentioned in the code. Also, it would be better not to "#error" if the arch isn't one of those fortunate, because ltp should build on others too. This should be fixed by patch 1.
Disclaimer: This patch should make it compile (and fail at runtime with TCONF) on all kernels that don't have the syscall, and actually run the test on all kernels that do, depending on kernel headers version. However, I didn't test this (especially the selection of the syscall), so it needs to be checked.
Second, if any of the syscalls vital for the test fails, it's preferable to output the error message too, and call tst_brk() for cleanup (patch 2).
Third, there it would probably be better to use TFAIL/TPASS for recording success and failure instead of manual boolean flags (patch 3).
Last, I think a successful test should print as little as possible and multiline messages like "calling syscall..." are really not that useful. Patch 4 disables them.
Regards
Jiri Palecek
0001-Compile-the-accept4-test-on-kernels-that-lack-it.patch
Description: Binary data
0002-Use-tst_brkm-TBROK-for-broken-tests.patch
Description: Binary data
0003-Use-TFAIL-TPASS-for-failure-tracking.patch
Description: Binary data
0004-Get-rid-of-useless-output.patch
Description: Binary data
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
