Its no good to redirect the error messages from the binaries to /dev/null. One
might not know what is the failure or what went wrong. This patch omits that
redirection.
Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]>
Index:
ltp-full-20081031/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh
===================================================================
---
ltp-full-20081031.orig/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh
+++
ltp-full-20081031/testcases/kernel/controllers/cpuctl/run_cpuctl_stress_test.sh
@@ -158,12 +158,12 @@ usage ()
for j in $(seq 1 $TASKS_IN_GROUP)
do
TASK_NUM=`expr $TASK_NUM + 1`;
- cp cpuctl_test03 cpuctl_task_$TASK_NUM 2>/dev/null;
+ cp cpuctl_test03 cpuctl_task_$TASK_NUM ;
chmod +x cpuctl_task_$TASK_NUM;
GROUP_NUM=$i MYGROUP=$MYGROUP SCRIPT_PID=$SCRIPT_PID
NUM_CPUS=$NUM_CPUS \
TEST_NUM=$TEST_NUM TASK_NUM=$TASK_NUM
./cpuctl_task_$TASK_NUM \
- >>$LTPROOT/output/cpuctl_results_$FILE.txt 2>/dev/null &
+ >>$LTPROOT/output/cpuctl_results_$FILE.txt &
if [ $? -ne 0 ]
then
echo "Error: Could not run
./cpuctl_task_$TASK_NUM"
@@ -202,7 +202,7 @@ usage ()
for j in $(seq 1 $TASKS_IN_GROUP)
do
TASK_NUM=`expr $TASK_NUM + 1`;
- cp cpuctl_test04 cpuctl_task_$TASK_NUM 2>/dev/null;
+ cp cpuctl_test04 cpuctl_task_$TASK_NUM ;
chmod +x cpuctl_task_$TASK_NUM;
# Per group nice value change must not affect
group/task fairness
@@ -221,7 +221,7 @@ usage ()
GROUP_NUM=$i MYGROUP=$MYGROUP SCRIPT_PID=$SCRIPT_PID
NUM_CPUS=$NUM_CPUS \
TEST_NUM=$TEST_NUM TASK_NUM=$TASK_NUM nice -n
$NICEVALUE ./cpuctl_task_$TASK_NUM \
- >>$LTPROOT/output/cpuctl_results_$FILE.txt 2>/dev/null &
+ >>$LTPROOT/output/cpuctl_results_$FILE.txt &
if [ $? -ne 0 ]
then
echo "Error: Could not run
./cpuctl_task_$TASK_NUM"
@@ -262,12 +262,12 @@ usage ()
for j in $(seq 1 $TASKS_IN_GROUP)
do
TASK_NUM=`expr $TASK_NUM + 1`;
- cp cpuctl_test04 cpuctl_task_$TASK_NUM 2>/dev/null;
+ cp cpuctl_test04 cpuctl_task_$TASK_NUM ;
chmod +x cpuctl_task_$TASK_NUM;
GROUP_NUM=$i MYGROUP=$MYGROUP SCRIPT_PID=$SCRIPT_PID
NUM_CPUS=$NUM_CPUS \
TEST_NUM=$TEST_NUM TASK_NUM=$TASK_NUM
./cpuctl_task_$TASK_NUM \
- >>$LTPROOT/output/cpuctl_results_$FILE.txt 2>/dev/null &
+ >>$LTPROOT/output/cpuctl_results_$FILE.txt &
if [ $? -ne 0 ]
then
echo "Error: Could not run
./cpuctl_task_$TASK_NUM"
Index: ltp-full-20081031/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh
===================================================================
---
ltp-full-20081031.orig/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh
+++ ltp-full-20081031/testcases/kernel/controllers/cpuctl/run_cpuctl_test.sh
@@ -107,10 +107,10 @@ NUM_CPUS=`cat /proc/cpuinfo | grep -w pr
echo NUM_GROUPS=$NUM_GROUPS >>
$LTPROOT/output/cpuctl_results_$FILE.txt;
for i in $(seq 1 $NUM_GROUPS)
do
- cp cpuctl_test01 cpuctl_task_$i 2>/dev/null;
+ cp cpuctl_test01 cpuctl_task_$i ;
chmod +x cpuctl_task_$i;
./cpuctl_task_$i $i /dev/cpuctl/group_$i $$ $NUM_CPUS
$TEST_NUM \
- >>$LTPROOT/output/cpuctl_results_$FILE.txt 2>/dev/null
&
+ >>$LTPROOT/output/cpuctl_results_$FILE.txt &
if [ $? -ne 0 ]
then
echo "Error: Could not run ./cpuctl_task_$i"
@@ -142,7 +142,7 @@ NUM_CPUS=`cat /proc/cpuinfo | grep -w pr
for j in $(seq 1 $TASKS_IN_GROUP)
do
TASK_NUM=`expr $TASK_NUM + 1`;
- cp cpuctl_test02 cpuctl_task_$TASK_NUM 2>/dev/null;
+ cp cpuctl_test02 cpuctl_task_$TASK_NUM ;
chmod +x cpuctl_task_$TASK_NUM;
if [ $i -eq 1 ] # Renice all tasks of group 1
then
@@ -153,7 +153,7 @@ NUM_CPUS=`cat /proc/cpuinfo | grep -w pr
GROUP_NUM=$i MYGROUP=$MYGROUP SCRIPT_PID=$SCRIPT_PID
NUM_CPUS=$NUM_CPUS \
TEST_NUM=$TEST_NUM TASK_NUM=$TASK_NUM nice -n
$NICELEVEL ./cpuctl_task_$TASK_NUM \
- >>$LTPROOT/output/cpuctl_results_$FILE.txt 2>/dev/null &
+ >>$LTPROOT/output/cpuctl_results_$FILE.txt &
if [ $? -ne 0 ]
then
echo "Error: Could not run
./cpuctl_task_$TASK_NUM"
@@ -187,12 +187,12 @@ NUM_CPUS=`cat /proc/cpuinfo | grep -w pr
for j in $(seq 1 $TASKS_IN_GROUP)
do
TASK_NUM=`expr $TASK_NUM + 1`;
- cp cpuctl_test02 cpuctl_task_$TASK_NUM 2>/dev/null;
+ cp cpuctl_test02 cpuctl_task_$TASK_NUM ;
chmod +x cpuctl_task_$TASK_NUM;
GROUP_NUM=$i MYGROUP=$MYGROUP SCRIPT_PID=$SCRIPT_PID
NUM_CPUS=$NUM_CPUS \
TEST_NUM=$TEST_NUM TASK_NUM=$TASK_NUM
./cpuctl_task_$TASK_NUM \
- >>$LTPROOT/output/cpuctl_results_$FILE.txt 2>/dev/null &
+ >>$LTPROOT/output/cpuctl_results_$FILE.txt &
if [ $? -ne 0 ]
then
echo "Error: Could not run
./cpuctl_task_$TASK_NUM"
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
