On 18:29 Thu 11 Dec 2008, Subrata Modak wrote:
> Hi Brandon,
>
> On Mon, 2008-12-08 at 21:05 -0800, Brandon Philips wrote:
> > Version 2: The test failed a few hours after I sent this off. I think it
> > was caused by a pid collision which caused the test to use the same
> > queue as an earlier failed test that didn't close out its queue. This
> > version of the test uses O_EXCL to avoid this. And it cleans up the
> > queue on every failure case.
> >
> > This test was racy. It relied on signals interrupting sleeps to do
> > syncronization between processes. It also didn't cleanup the queue on
> > the failure cases and assumed that its queue didn't already exist. This
> > patch fixes these issues.
> >
> > Reported failures: https://bugzilla.novell.com/show_bug.cgi?id=375897
> >
> > Instead use a syncronization pipe to have the child thread send messages
> > to the parent thread (with reasonable timeouts since this is testing
> > blocking calls).
> >
> > # Apply to root of ltp-full-20081031 tree
> >
> > $ cd testcases/open_posix_testsuite/
> > $ make conformance/interfaces/mq_send/5-1.test
> > $ conformance/interfaces/mq_send/5-1.test
> >
> > Signed-off-by: Brandon Philips <[email protected]>
>
> Thanks for the Patch. Can you please resend it across the present LTP
> CVS snapshot, or even the latest Nov 2008 release will do. I find the
> following problems in applying the same:
>
> $ patch --dry-run -p1 < mq_send-5-1.c.patch
> patching file
> testcases/open_posix_testsuite/conformance/interfaces/mq_send/5-1.c
> patching file testcases/open_posix_testsuite/include/posixtest.h
> Hunk #1 FAILED at 14.
> 1 out of 1 hunk FAILED -- saving rejects to file
> testcases/open_posix_testsuite/include/posixtest.h.rej
It applies fine to the Nov 2008 release for me. What are the rejects?
They should be trivial to fix up against posixtest.h....
Cheers,
Brandon
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
