--- On Fri, 12/12/08, Andrew Vagin <[email protected]> wrote: > From: Andrew Vagin <[email protected]> > Subject: [LTP] [PATCH] commands/unzip: check exit code of all comands > To: [email protected] > Cc: "Andrew Vagin" <[email protected]> > Date: Friday, December 12, 2008, 12:36 AM > From: Andrew Vagin <[email protected]> > > 1. don't redirect all output to /dev/null. It's bad > idea, because we can't > investigate bugs without error messages. > 2. check exit code of command "zip". If it > failed, we get error during > make install that can't found a zip file. > --- > testcases/commands/unzip/unzip_genfile.sh | 20 > +++++++++++++++----- > 1 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/testcases/commands/unzip/unzip_genfile.sh > b/testcases/commands/unzip/unzip_genfile.sh > index 643a3c6..c6e1b08 100755 > --- a/testcases/commands/unzip/unzip_genfile.sh > +++ b/testcases/commands/unzip/unzip_genfile.sh > @@ -41,10 +41,10 @@ RC=0 # return > value from commands > while [ $dircnt -lt $numdirs ] > do > dirname=$dirname/d.$dircnt > - mkdir -p $dirname &>/dev/null || RC=$? > + mkdir -p $dirname || RC=$? > if [ $RC -ne 0 ] > then > - echo "unzip_genfile.sh: ERROR: while creating > $numdirs dirs." > + echo "unzip_genfile.sh: ERROR: while creating > $numdirs dirs." 1>&2 > exit $RC > fi > fcnt=0 > @@ -53,7 +53,7 @@ do > touch $dirname/f.$fcnt > if [ $RC -ne 0 ] > then > - echo "unzip_genfile.sh: ERROR: creating $numdirs > dirs." > + echo "unzip_genfile.sh: ERROR: creating $numdirs > dirs." 1>&2 > exit $RC > fi > fcnt=$(($fcnt+1)) > @@ -63,8 +63,18 @@ done > > # Create ZIP file. > > -zip -r tst_unzip_file.zip /tmp/tst_unzip.dir > &>/dev/null > +zip -r tst_unzip_file.zip /tmp/tst_unzip.dir || RC=$? > +if [ $RC -ne 0 ] > +then > + echo "unzip_genfile.sh: ERROR: creating > tst_unzip_file.zip archive." 1>&2 > + exit $RC > +fi > > -rm -fr /tmp/tst_unzip.* &>/dev/null > +rm -fr /tmp/tst_unzip.* || RC=$? > +if [ $RC -ne 0 ] > +then > + echo "unzip_genfile.sh: ERROR: deleting tempory > files." 1>&2 > + exit $RC > +fi > > exit $RC > -- > 1.5.6.4 >
Acked-by: CAI Qian <[email protected]> > > ------------------------------------------------------------------------------ > SF.Net email is Sponsored by MIX09, March 18-20, 2009 in > Las Vegas, Nevada. > The future of the web can't happen without you. Join > us at MIX09 to help > pave the way to the Next Web now. Learn more and register > at > http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ > _______________________________________________ > Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
