hi Jacky, Which one you have tried?
is it original source or after applying the patch? Please share the results logs. Thanks & regards Naresh Kamboju On Fri, Dec 19, 2008 at 2:52 PM, Jacky Malcles <[email protected]>wrote: > I picked it up and did a try on a Red Hat distro, all is ok it's working > well, > > many thanks > > Subrata Modak a écrit : > > On Wed, 2008-12-17 at 14:19 +0530, naresh kamboju wrote: >> >> >>> thanks for reply subrata, >>> here i am attaching >>> >>> 1. tacl_xattr.patch >>> 2. org_output_tacl_xattr.log >>> 3. modified_output_tacl_xattr.log >>> >>> please find all above attachments. >>> >>> this is the patch have prepared. please review it. >>> >>> Signed-off-by: Naresh Kamboju<[email protected]> >>> >> >> Thanks. >> >> Regards-- >> Subrata >> >> >> >>> diff -Naurb ltp-full-20081130/testcases/kernel/fs/acl/tacl_xattr.sh >>> ltp-full-20081130_mod/testcases/kernel/fs/acl/tacl_xattr.sh >>> --- ltp-full-20081130/testcases/kernel/fs/acl/tacl_xattr.sh >>> 2004-10-15 00:21:39.000000000 +0530 >>> +++ ltp-full-20081130_mod/testcases/kernel/fs/acl/tacl_xattr.sh >>> 2008-12-17 13:53:13.000000000 +0530 >>> @@ -120,10 +120,10 @@ >>> chmod 777 tacl/mount-ext2 >>> -adduser -d `pwd`/tacl/tacluser1 tacluser1 >>> -adduser -d `pwd`/tacl/tacluser2 tacluser2 >>> -adduser -d `pwd`/tacl/tacluser3 tacluser3 >>> -adduser -d `pwd`/tacl/tacluser4 tacluser4 >>> +useradd -d `pwd`/tacl/tacluser1 tacluser1 >>> +useradd -d `pwd`/tacl/tacluser2 tacluser2 >>> +useradd -d `pwd`/tacl/tacluser3 tacluser3 >>> +useradd -d `pwd`/tacl/tacluser4 tacluser4 >>> if [ ! -e tacl/mount-ext2/shared ] >>> then >>> @@ -188,7 +188,7 @@ >>> fi >>> touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 >>> 2> /dev/null >>> - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ] >>> + if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ] >>> then >>> echo "" >>> echo "FAILED: [ touch ] Create file must be denied by file >>> permission bits" >>> >>> Thanks >>> Naresh >>> >>> On Wed, Dec 17, 2008 at 12:47 PM, Subrata Modak >>> <[email protected]> wrote: >>> On Fri, 2008-12-12 at 19:34 +0530, naresh kamboju wrote: >>> > >>> > >>> > Hi, >>> > >>> > >>> > >>> > I made few changes to >>> ltp/testcases/kernel/fs/acl/tacl_xattr.sh >>> > >>> > It is not working perfectly still there are issues with this >>> script >>> > >>> > I have posted patch and logs.attached strace log file >>> > >>> > >>> > please cross check results. >>> > >>> > >>> > >>> > Signed-off-by: Naresh Kamboju<[email protected]> >>> Thanks. Can you also please attach 2 different >>> outputs of this >>> run (pre >>> and post patch). I do not have the required setup now, that´s >>> why would >>> need them. And also, the Patch cannot be applied as embedded >>> in your >>> mail. Please attach the same as well. >>> Regards-- >>> Subrata >>> > >>> > >>> > --- tacl_xattr.sh.org 2008-12-12 18:51:54.000000000 +0000 >>> > >>> > +++ tacl_xattr.sh 2008-12-12 18:51:54.000000000 +0000 >>> > >>> > @@ -120,10 +120,10 @@ >>> > >>> > >>> > >>> > chmod 777 tacl/mount-ext2 >>> > >>> > >>> > >>> > -adduser -d `pwd`/tacl/tacluser1 tacluser1 >>> > >>> > -adduser -d `pwd`/tacl/tacluser2 tacluser2 >>> > >>> > -adduser -d `pwd`/tacl/tacluser3 tacluser3 >>> > >>> > -adduser -d `pwd`/tacl/tacluser4 tacluser4 >>> > >>> > +useradd -d `pwd`/tacl/tacluser1 tacluser1 >>> > >>> > +useradd -d `pwd`/tacl/tacluser2 tacluser2 >>> > >>> > +useradd -d `pwd`/tacl/tacluser3 tacluser3 >>> > >>> > +useradd -d `pwd`/tacl/tacluser4 tacluser4 >>> > >>> > >>> > >>> > if [ ! -e tacl/mount-ext2/shared ] >>> > >>> > then >>> > >>> > @@ -188,7 +188,7 @@ >>> > >>> > fi >>> > >>> > >>> > >>> > touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 >>> > 2> /dev/null >>> > >>> > - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ] >>> > >>> > + if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ] >>> > >>> > then >>> > >>> > echo "" >>> > >>> > echo "FAILED: [ touch ] Create file must be denied by >>> file >>> > permission bits" >>> > >>> > >>> > >>> > >>> > >>> > >>> /*****************************************************************/ >>> > >>> > >>> > Here is the Results log >>> > >>> > >>> > >>> /*****************************************************************/ >>> > >>> > >>> > 10240+0 records in >>> > >>> > 10240+0 records out >>> > >>> > /dev/sda2 on /mnt/HDD type ext2 (rw) >>> > >>> > mke2fs 1.40.8 (13-Mar-2008) >>> > >>> > Filesystem label= >>> > >>> > OS type: Linux >>> > >>> > Block size=1024 (log=0) >>> > >>> > Fragment size=1024 (log=0) >>> > >>> > 2560 inodes, 10240 blocks >>> > >>> > 512 blocks (5.00%) reserved for the super user >>> > >>> > First data block=1 >>> > >>> > Maximum filesystem blocks=10485760 >>> > >>> > 2 block groups >>> > >>> > 8192 blocks per group, 8192 fragments per group >>> > >>> > 1280 inodes per group >>> > >>> > Superblock backups stored on blocks: >>> > >>> > 8193 >>> > >>> > >>> > >>> > Writing inode tables: 0/2___1/2___done >>> > >>> > Writing superblocks and filesystem accounting information: >>> done >>> > >>> > >>> > >>> > This filesystem will be automatically checked every 35 >>> mounts or >>> > >>> > 180 days, whichever comes first. Use tune2fs -c or -i to >>> override. >>> > >>> > >>> > >>> > SUCCESS: Create file denied by file permission bits >>> [ Physical >>> > directory ] >>> > >>> > >>> > >>> > SUCCESS: Create file denied by file permission bits >>> [ Symlink >>> > directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER_OBJ entry contains the owner execute >>> permissions, >>> > >>> > operation success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER_OBJ entry contains the owner execute >>> permissions, >>> > >>> > operation success [ Symlink Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER_OBJ entry contains the owner write >>> permissions, >>> > >>> > operation success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER_OBJ entry contains the owner write >>> permissions, >>> > >>> > operation success [ Symlink Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER entry contains the user permissions, >>> > >>> > operation success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER entry contains the user permissions, >>> > >>> > operation success [ Symlink Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER entry contains the user permissions, >>> > >>> > but ACL_MASK are set ___ , >>> > >>> > operation success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_USER entry contains the user permissions, >>> > >>> > but ACL_MASK are set ___ , >>> > >>> > operation success [ Symlink Directory ] >>> > >>> > setfacl: Option -m: Invalid argument near character 3 >>> > >>> > >>> > >>> > FAILED: [ touch ] ACL_GROUP entry already contains the >>> group >>> > permissions, >>> > >>> > but option success [ Physical Directory ] >>> > >>> > >>> > >>> > FAILED: [ touch ] ACL_GROUP entry already contains the >>> group >>> > permissions, >>> > >>> > but option success [ Symlink Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_GROUP entry already contains the group >>> permissions >>> > >>> > and ACL_MASK entry are set ---, >>> > >>> > option success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_GROUP entry already contains the group >>> permissions >>> > >>> > and ACL_MASK entry are set ---, >>> > >>> > option success [ Symlink Directory ] >>> > >>> > usermod: unknown group tacluser1 >>> > >>> > >>> > >>> > SUCCESS: ACL_GROUP_OBJ entry contains the group owner >>> permissions, >>> > >>> > option success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_GROUP_OBJ entry contains the group owner >>> permissions, >>> > >>> > option success [ Symlink Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_GROUP_OBJ entry already contains the group >>> owner >>> > permissions >>> > >>> > and ACL_MASK entry are set ---, >>> > >>> > option success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_GROUP_OBJ entry already contains the group >>> owner >>> > permissions >>> > >>> > and ACL_MASK entry are set ---, >>> > >>> > option success [ Symlink Directory ] >>> > >>> > usermod: unknown group tacluser2 >>> > >>> > >>> > >>> > SUCCESS: ACL_OTHER entry contains the user permissions, >>> > >>> > operation success [ Physical Directory ] >>> > >>> > >>> > >>> > SUCCESS: ACL_OTHER entry contains the user permissions, >>> > >>> > operation success [ Symlink Directory ] >>> > >>> > >>> > >>> > FAILED: ACL_OTHER do not strick by ACL_MASK [ Physical >>> Directory ] >>> > >>> > >>> > >>> > FAILED: ACL_OTHER do not strick by ACL_MASK [ Symlink >>> Directory ] >>> > >>> > >>> > >>> > SUCCESS: With default ACLs set , new file permission set >>> correct. >>> > >>> > setfacl: Option -m: Invalid argument near character 5 >>> > >>> > >>> touch: >>> /mnt/HDD/ltp-full-20081130/testcases/kernel/fs/acl/tacl/mount-ext2/shared/team1/newfile2: >>> Permission denied >>> > >>> > ls: tacl/mount-ext2/shared/team1/newfile2: No such file or >>> directory >>> > >>> > tacl_xattr.sh: line 612: [: !=: unary operator expected >>> > >>> > >>> > >>> > FAILED: With default ACLs set , new file permission set not >>> correct >>> > >>> > >>> touch: >>> /mnt/HDD/ltp-full-20081130/testcases/kernel/fs/acl/tacl/mount-ext2/shared/team1/newfile3: >>> Permission denied >>> > >>> > ls: tacl/mount-ext2/shared/team1/newfile3: No such file or >>> directory >>> > >>> > tacl_xattr.sh: line 639: [: !=: unary operator expected >>> > >>> > >>> > >>> > FAILED: With default ACLs set , new file permission set not >>> correct >>> > >>> > >>> chmod: >>> /mnt/HDD/ltp-full-20081130/testcases/kernel/fs/acl/tacl/mount-ext2/shared/team1/newfile3: >>> Permission denied >>> > >>> > getfacl: tacl/mount-ext2/shared/team1/newfile3: No such file >>> or >>> > directory >>> > >>> > tacl_xattr.sh: line 670: [: ==: unary operator expected >>> > >>> > >>> > >>> > FAILED: Chmod with ACL_USER_OBJ ACL_GROUP_OBJ and ACL_OTHER >>> are not >>> > correct >>> > >>> > chown: unknown user/group tacluser2:tacluser2 >>> > >>> > getfacl: tacl/mount-ext2/shared/team1/newfile2: No such file >>> or >>> > directory >>> > >>> > tacl_xattr.sh: line 705: [: ==: unary operator expected >>> > >>> > FAILED: Chown are not correct >>> > >>> > >>> > >>> > SUCCESS: ACLs backup and restore are correct >>> > >>> > >>> > >>> > End ACLs Test >>> > >>> > >>> > >>> > Now begin Extend Attribute Test >>> > >>> > >>> > >>> > Attach name:value pair to object dir >>> > >>> > >>> > >>> > Attribute "attrname1" set to a 10 byte value for >>> > tacl/mount-ext2/shared/team2: >>> > >>> > attrvalue1 >>> > >>> > >>> > >>> > Attach name:value pair to object file >>> > >>> > >>> > >>> > Attribute "attrname2" set to a 10 byte value for >>> > tacl/mount-ext2/shared/team2/file1: >>> > >>> > attrvalue2 >>> > >>> > >>> > >>> > Attach name:value pair to object symlink file >>> > >>> > >>> > >>> > attr_set: Operation not permitted >>> > >>> > Could not set "attrname3" for >>> > tacl/mount-ext2/shared/team2/symlinkfile1 >>> > >>> > INFO: Can't attach name:value pair to object symlink file >>> > >>> > >>> > >>> > tacl/mount-ext2/shared/team2: >>> > >>> > -rw-r--r-- 1 tacluser users 0 Jan 9 02:18 >>> file1 >>> > >>> > lrwxrwxrwx 1 tacluser users 5 Jan 9 02:18 >>> symlinkfile1 >>> > -> file1 >>> > >>> > >>> > >>> > get extended attributes of filesystem objects >>> > >>> > >>> > >>> > Dump the values >>> > >>> > # file: tacl/mount-ext2/shared/team2 >>> > >>> > user.attrname1="attrvalue1" >>> > >>> > >>> > >>> > Recursively dump the values >>> > >>> > # file: tacl/mount-ext2/shared/team2 >>> > >>> > user.attrname1="attrvalue1" >>> > >>> > >>> > >>> > # file: tacl/mount-ext2/shared/team2/file1 >>> > >>> > user.attrname2="attrvalue2" >>> > >>> > >>> > >>> > # file: tacl/mount-ext2/shared/team2/symlinkfile1 >>> > >>> > user.attrname2="attrvalue2" >>> > >>> > >>> > >>> > Do not follow symlinks. >>> > >>> > but extended user attributes are disallowed for symbolic >>> links >>> > >>> > >>> > >>> > Logical walk, follow symbolic links >>> > >>> > # file: tacl/mount-ext2/shared/team2/file1 >>> > >>> > user.attrname2 >>> > >>> > >>> > >>> > # file: tacl/mount-ext2/shared/team2/symlinkfile1 >>> > >>> > user.attrname2 >>> > >>> > >>> > >>> > Physical walk, skip all symbolic links >>> > >>> > # file: tacl/mount-ext2/shared/team2/file1 >>> > >>> > user.attrname2 >>> > >>> > >>> > >>> > attr -g to search the named object >>> > >>> > Attribute "attrname1" had a 10 byte value for >>> > tacl/mount-ext2/shared/team2: >>> > >>> > attrvalue1 >>> > >>> > >>> > >>> > attr -r to remove the named object >>> > >>> > >>> > >>> > SUCCESS: EAs backup and restore are correct >>> > >>> > >>> > >>> > End EAs Test >>> > >>> > >>> > >>> > >>> > >>> > Thanks & regards >>> > >>> > Naresh Kamboju >>> > >>> > >>> > >>> > >>> > >>> > >>> >>> >>> >> >> >> >> >> > > -- > Jacky Malcles B1-403 Email : [email protected] > Bull SA, 1 rue de Provence, B.P 208, 38432 Echirolles CEDEX, FRANCE > Tel : 04.76.29.73.14 > >
------------------------------------------------------------------------------
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
