On Mon, 2009-01-12 at 10:54 +0530, Vinay Sridhar wrote:
> On Monday 15 December 2008 06:59:44 pm Subrata Modak wrote:
> > On Mon, 2008-12-15 at 17:33 +0530, Vinay Sridhar wrote:
> > > Subrata,
> > >
> > > A while back I had submitted an LTP patch for the vmsplice01 test case
> > > (sent on 03/27/2008).
> > > However, the code I see in the vmsplice01.c file now is not what the
> > > patch contains.
> > >
> > > /*
> > > * check if the current filesystem is nfs
> > > */
> > > if(tst_is_cwd_nfs()) {
> > > if (flag == 1)
> > > printf("vmsplice01 1 PASS : vmplice() passes\n");
> > >
> > > else <========= (there is no "else" in my patch)
> > >
> > > tst_brkm(TCONF, cleanup, "Cannot do splice() on a file located on
> > > an NFS filesystem");
> > > }
> > >
> > > Please consider the modification for the next LTP release.
> > >
> > > Thanks,
> > > Vinay
> > >
> > >
> > > Patch sent on 27th March 2008 :
> > >
> > >
> > > Signed-off-by : Vinay Sridhar <[email protected]>
> >
> > Thanks Vinay. I think the changes are there and hence i received the
> > following messages while applying:
> >
> > missing header for unified diff at line 100 of patch
> > patching file testcases/kernel/syscalls/vmsplice/vmsplice01.c
> > Reversed (or previously applied) patch detected! Assume -R? [n]
> >
> > Can you please send your changes against the latest code as on
> > 15-Dec-2008 ?
> >
> > Regards--
> > Subrata
>
>
> Subrata,
>
> Please find below the correction against the latest ltp release :
>
> Signed-off by: Vinay Sridhar <[email protected]>
Thanks Vinay.
Regards-
Subrata
>
> diff -Nuarp
> ltp-full-20081231_orig//testcases/kernel/syscalls/vmsplice/vmsplice01.c
> ltp-full-20081231/testcases/kernel/syscalls/vmsplice/vmsplice01.c
> --- ltp-full-20081231_orig//testcases/kernel/syscalls/vmsplice/vmsplice01.c
> 2008-06-14 02:01:40.000000000 -0500
> +++ ltp-full-20081231/testcases/kernel/syscalls/vmsplice/vmsplice01.c
> 2009-01-11 06:17:40.000000000 -0600
> @@ -218,10 +218,10 @@ static int vmsplice_test(void)
> * check if the current filesystem is nfs
> */
> if(tst_is_cwd_nfs()) {
> - if (flag == 1)
> - printf("vmsplice01 1 PASS :
> vmplice() passes\n");
> - else
> - tst_brkm(TCONF, cleanup, "Cannot do
> splice() on a file located on an NFS filesystem");
> + if (flag == 1)
> + tst_resm(TINFO, "vmplice() passes");
> + tst_brkm(TCONF, cleanup, "Cannot do splice() "
> + "on a file located on an NFS filesystem");
> }
>
>
>
> ---
> Vinay Sridhar,
> Linux Technology Centre,
> IBM ISTL,
> Bangalore, India
>
>
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
