On Tuesday 13 January 2009 07:32:26 Edjunior Barbosa Machado wrote: > Mike Frysinger wrote: > > On Tuesday 13 January 2009 01:31:47 Subrata Modak wrote: > >> +CFLAGS += -I../../../include -Wall > > > > -I options are CPPFLAGS, not CFLAGS > > > >> +LDLIBS += -L../../../lib -lltp > > > > -L options are LDFLAGS, not LDLIBS > > > >> tcore: tcore.c > >> - $(CC) -o tcore tcore.c -lm -lpthread > >> + $(CC) -o tcore tcore.c $(CFLAGS) $(LDLIBS) -lm -lpthread > > > > i would delete the rule altogether and set LDLIBS/LDFLAGS properly > > agree with you Mike, but, just for let you know, I used the Makefiles > included in ltp/testcases/misc/crash and ltp/testcases/misc/f00f as > examples, and both are using CFLAGS and LOADLIBES variables.
yes, there has been too much "put all CPPFLAGS into CFLAGS and dont use CPPFLAGS" in the tree. it isnt a critical issue, but one we should be fixing as we go rather than introducing more of the same. as for LOADLIBES vs LDLIBS, i believe the difference is that LOADLIBES are local libraries (i.e. static archives from the package -- liblta.a) while LDLIBS are external libraries (i.e. things like -lrt or -lcap or ...). but that might be more my opinion than reality :). i'm happy as long as one of those variables is being used instead of LDFLAGS. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
