On Friday 16 January 2009 09:21:31 Masatake YAMATO wrote: > > On Thu, 2009-01-15 at 10:31 -0500, Mike Frysinger wrote: > > > On Thursday 15 January 2009 01:56:47 Masatake YAMATO wrote: > > > > --- a/Makefile > > > > +++ b/Makefile > > > > > > not sure we want to encourage "documentation-in-the-build-system". > > > could you add this stuff to INSTALL instead ? when people think "how > > > do i build this package", i'd think they'd (or at least they should) > > > look at the documentation first rather than the build system. > > > > True, > > > > Yamato, can you please resend as per Mike´s comments ? > > Signed-off-by: Masatake YAMATO <yam...@redhat.com>
patch looks fine ... if Subrata doesnt merge it, i'll get around to it some point this weekend > +To cross compile, override one or more of CC, AR, CROSS_CFLAGS, > +LOADLIBES, LDFLAGS, & LIB_DIR and be sure to always build from the top > level. unrelated to your change but something we should review in the future ... CROSS_CFLAGS/LOADLIBES/LIB_DIR look very suspicious (i.e. wrong) to me. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
