On Fri, 2009-01-23 at 13:55 -0800, Garrett Cooper wrote:
> On Fri, Jan 23, 2009 at 3:42 AM, Subrata Modak
> <[email protected]> wrote:
> > Signed-Off-By: Subrata Modak<[email protected]>,
> > --
> > diff -uprN
> > ltp-intermediate-20090121/testcases/kernel/io/direct_io/test_dma_thread_diotest7.sh
> >  
> > ltp-intermediate-20090121.modified/testcases/kernel/io/direct_io/test_dma_thread_diotest7.sh
> > ---
> > ltp-intermediate-20090121/testcases/kernel/io/direct_io/test_dma_thread_diotest7.sh
> >  1970-01-01 05:30:00.000000000 +0530
> > +++
> > ltp-intermediate-20090121.modified/testcases/kernel/io/direct_io/test_dma_thread_diotest7.sh
> >  2009-01-23 16:29:22.000000000 +0530
> > @@ -0,0 +1,38 @@
> > +#! /bin/sh
> > +################################################################################
> > +##
> > ##
> > +## Copyright (c) International Business Machines  Corp., 2009
> > ##
> > +## Copyright (c) Li Zefan <[email protected]>, 2009
> > ##
> > +##
> > ##
> > +## This program is free software;  you can redistribute it and#or
> > modify      ##
> > +## it under the terms of the GNU General Public License as published by
> > ##
> > +## the Free Software Foundation; either version 2 of the License, or
> > ##
> > +## (at your option) any later version.
> > ##
> > +##
> > ##
> > +## This program is distributed in the hope that it will be useful, but
> > ##
> > +## WITHOUT ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY ##
> > +## or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
> > License   ##
> > +## for more details.
> > ##
> > +##
> > ##
> > +## You should have received a copy of the GNU General Public License
> > ##
> > +## along with this program;  if not, write to the Free Software
> > ##
> > +## Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > USA    ##
> > +##
> > ##
> > +################################################################################
> > +
> > +tst_resm TINFO "Generating Test Files"
> > +./dma_thread_diotest7
> > +
> > +# test different alignments: 512, 1024, ..., (4096-512)
> > +for ((i = 512; i < 4096; i+=512))
> > +do
> > +        tst_resm TINFO "i=$i"
> > +        ./dma_thread_diotest7 -a=`echo $i`
> > +        if [ $? -ne 0 ]; then
> > +             tst_res TFAIL "Test Failed"
> > +             exit 1
> > +        else
> > +             tst_resm TPASS "Test Passed"
> > +        fi
> > +done
> > +exit 0;
> 
> This could be simplified as follows (unless you REALLY need the
> newline provided by `echo $i`...):
> 
>         if ./dma_thread_diotest7 -a="$i"; then

Thanks. I will include this.

Regards--
Subrata

>              tst_res TFAIL "Test Failed"
>              exit 1
>         else
>              tst_resm TPASS "Test Passed"
>         fi
> 
> Cheers,
> -Garrett


------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to