On Wed, 2009-02-25 at 20:42 -0800, Matt Helsley wrote: > Review of these test source files suggests that absolutley no capability APIs > are in use. I suspect these #ifdefs were added because the original > tests had unnecessarily included sys/capability.h
True. This was pointed to by Serge earlier. But the fix was postponed till we have to fix something else in those tests. Thanks you fixed it earlier. Regards-- Subrata > > Signed-off-by: Matt Helsley <[email protected]> > --- > testcases/kernel/containers/pidns/pidns14.c | 17 ----------------- > testcases/kernel/containers/pidns/pidns16.c | 17 ----------------- > 2 files changed, 34 deletions(-) > > Index: ltp/testcases/kernel/containers/pidns/pidns14.c > =================================================================== > --- ltp.orig/testcases/kernel/containers/pidns/pidns14.c > +++ ltp/testcases/kernel/containers/pidns/pidns14.c > @@ -43,9 +43,6 @@ > #include <test.h> > #include <libclone.h> > > -#if defined(HAVE_SYS_CAPABILITY) > -#include <sys/capability.h> > - > char *TCID = "pidns14"; > int TST_TOTAL = 1; > > @@ -123,17 +120,3 @@ int main(int argc, char *argv[]) > > return 0; > } /* End main */ > - > -#else > - > -char *TCID = "pidns14"; > -int TST_TOTAL = 0; /* Total number of test cases. */ > - > -int > -main() > -{ > - tst_resm(TBROK, "can't find header sys/capability.h"); > - return 1; > -} > - > -#endif > Index: ltp/testcases/kernel/containers/pidns/pidns16.c > =================================================================== > --- ltp.orig/testcases/kernel/containers/pidns/pidns16.c > +++ ltp/testcases/kernel/containers/pidns/pidns16.c > @@ -52,9 +52,6 @@ > #define CHILD_PID 1 > #define PARENT_PID 0 > > -#if defined(HAVE_SYS_CAPABILITY) > -#include <sys/capability.h> > - > char *TCID = "pidns16"; > int TST_TOTAL = 1; > pid_t globalpid; > @@ -158,17 +155,3 @@ int main(int argc, char *argv[]) > cleanup(); > return 0; > } /* End main */ > - > -#else > - > -char *TCID = "pidns16"; > -int TST_TOTAL = 0; /* Total number of test cases. */ > - > -int > -main() > -{ > - tst_resm(TBROK, "can't find header sys/capability.h"); > - return 1; > -} > - > -#endif ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
