> On Monday 02 March 2009 07:56:19 Michal Simek wrote: > >> I think that is the right time to start with arch dependent compilation. >> Here is the patch which solve my problem with hyperthreading compilation. >> >> Mike: Any comments? If not I'll prepare proper patch for Subrata. >> >> --- a/Makefile >> +++ b/Makefile >> +ifndef ARCH >> +ARCH=i386 >> +endif >> > > this is no good imo. the ARCH should either be discovered automatically, or > not at all. > Arch should be discover automatically for systems where you compile LTP but not when you cross compile on x86 for different arch. > >> --- a/testcases/kernel/sched/Makefile >> +++ b/testcases/kernel/sched/Makefile >> +ifeq ($(ARCH),i386) >> +SUBDIRS += hyperthreading >> +endif >> > > i thought the code already had #ifdef's in it you could fix up easily ? > -mike > Some ifdefs are there but the question is why we should compile tests which we don't need for non x86 arch. Ifdef which are there are only for i[3-6]86. This covered only cases when you compile ltp on powerpc for powerpc test - that's work. Adding more ifdef to code seems to me useless.
Thanks, Michal -- Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663 ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
