On Tue, 2009-03-17 at 15:25 +0530, Chandru wrote:
> The epoll-ltp testcase tests zero size argument to epoll_create and reports 
> that particular case as a failure if the kernel returned a positive integer. 
> According to 'man epoll_create', this size argument is actually ignored and 
> the kernel dynamically sizes the required data structures. Hence removing 
> this check in epoll-ltp testcase. 
> 
> 
> Signed-Off-By: Chandru S <[email protected]>
> ---

I do not find it in 2.6.18, however reproducible on 2.6.28. Thanks for
the Fix.

Regards--
Subrata

> 
>  testcases/kernel/syscalls/epoll/epoll-ltp.c |   17 -----------------
>  1 file changed, 17 deletions(-)
> 
> --- a/testcases/kernel/syscalls/epoll/epoll-ltp.c.orig        2009-03-13 
> 11:20:40.000000000 -0400
> +++ a/testcases/kernel/syscalls/epoll/epoll-ltp.c     2009-03-17 
> 03:46:40.000000000 -0400
> @@ -240,23 +240,6 @@ int test_epoll_create (unsigned int num_
>       }
>    }
> 
> -  /* Zero set sizes */
> -  errno = 0;
> -  fd_set_size = 0;
> -  num_epoll_create_test_calls++;
> -  epoll_fd = epoll_create(fd_set_size);
> -  if (epoll_fd >= 0){
> -     tst_resm(TFAIL, "epoll_create with zero set size returned a valid fd 
> (errno = %d:%s)", errno, strerror(errno));
> -     num_epoll_create_test_fails++;
> -     close(epoll_fd);
> -  } else {
> -     if (errno != EINVAL){
> -       tst_resm(TFAIL, "epoll_create with zero set size failed to set errno 
> to EINVAL (%d:%s)", errno, strerror(errno));
> -       num_epoll_create_test_fails++;
> -     } else {
> -       tst_resm(TPASS, "epoll_create with zero set size");
> -     }
> -  }
> 
>    /* Large set sizes -- try several less than or equal to INT_MAX by some
>       small amount (expect num_rand_attempts to be approximately the
> 
> 
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to