On Sun, 2009-05-17 at 23:56 -0700, rohit verma wrote: > Dear Subrata, > > I have removed the warning and error and attached the updated patch > with this mail. > > I request you to apply the patch and let me know if any issues.
Thanks. > Request: Could you share the patch (checkpatch.pl ) which you have > developed, so that I can cross check it at my end for future patches > before sending to the ltp-list . It is available with the kernel source code: linux-2.6*/scripts/checkpatch.pl Regards-- Subrata > > Regards, > Rohit > > > On Fri, May 15, 2009 at 12:28 AM, Subrata Modak > <[email protected]> wrote: > Thanks. > > I have started to do some holy job, might be in annoyance to > everybody, > to check all patches with checkpatch.pl before they are merged > with > LTP. > > So, i would inform you what needs to be changed in the patch > before they > can be merged. This exercise will help us in preventing any > code mess as > we keep growing, and help maintaining LTP better. Hope, you > will agree > too. > > Your patch contains the following errors/warning. Please > rectify and > resend :-) > > > ======================================================================== > WARNING: line over 80 characters > #40: FILE: testcases/commands/unzip/unzip_tests.sh:152: > + diff -iwB "$PWD/tst_unzip.out" > "$PWD/tst_unzip.out.exp" > > "$PWD/tst_unzip.out.err" || RC=$? > > ERROR: Missing Signed-off-by: line(s) > > total: 1 errors, 1 warnings, 49 lines checked > > ======================================================================== > > Regards-- > Subrata > > On Thu, 2009-05-14 at 09:32 +0530, rohit verma wrote: > > > > > > ---------- Forwarded message ---------- > > From: CAI Qian <[email protected]> > > Date: Wed, May 13, 2009 at 8:05 PM > > Subject: Re: Patch for [LTP] :Unzip01 Test Not Working > Correctly > > To: [email protected] > > > > > > From: rohit verma <[email protected]> > > Subject: Re: Patch for [LTP] :Unzip01 Test Not Working > Correctly > > > > Date: Tue, 12 May 2009 17:10:36 +0530 > > > > > Hi Qian, > > > > > > Yes you are correct. We cannot predict the output order of > unzip. So > > I > > > have sorted the > > > actual and expected output and attached the updated patch > with this > > mail. > > > > > > I request you to apply this patch and let me know if any > issues. > > > > > > Regards, > > > Rohit > > > > > > > > > Works fine. Please submit to the mailing list. > > > > Acked-by: CAI Qian <[email protected]> > > > > Thanks, > > CAI Qian > > > > > > > > > > ------------------------------------------------------------------------------ > > The NEW KODAK i700 Series Scanners deliver under ANY > circumstances! Your > > production scanning environment may not be a perfect world - > but thanks to > > Kodak, there's a perfect scanner to get the job done! With > the NEW KODAK i700 > > Series Scanner you'll get full speed at 300 dpi even with > all image > > processing features enabled. http://p.sf.net/sfu/kodak-com > > _______________________________________________ Ltp-list > mailing list [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list > > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
