On Mon, 2009-06-08 at 14:13 +0800, Wei Yongjun wrote:
> Refer to the manpage:
>
> # man 2 chmod
> If the calling process is not privileged (Linux: does not have the
> CAP_FSETID capability), and the group of the file does not match
> the effective group ID of the process or one of its supplementary
> group IDs, the S_ISGID bit will be turned off, but this will not
> cause an error to be returned.
>
> So, if we want S_ISGID bit be turned off after chmod(), we can not have
> the CAP_FSETID capability and not match the effective group ID. The 'bin'
> group always has the CAP_FSETID capability, so we can not change the own
> of the TESTDIR to 'bin' group, instead, 'nobody' can be used.
>
> This patch fixed the problem by change gid of chown to 'nobody' group and
> change the gid of setegid() to 'bin' group.
>
> Signed-off-by: Wei Yongjun <[email protected]>
Thanks.
Regards--
Subrata
> ---
> testcases/kernel/syscalls/chmod/chmod05.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/chmod/chmod05.c
> b/testcases/kernel/syscalls/chmod/chmod05.c
> index 4504aaa..c6f1225 100644
> --- a/testcases/kernel/syscalls/chmod/chmod05.c
> +++ b/testcases/kernel/syscalls/chmod/chmod05.c
> @@ -177,7 +177,7 @@ int main(int ac, char **av)
> if ((PERMS & ~S_ISGID) != dir_mode) {
> tst_resm(TFAIL, "%s: Incorrect modes 0%03o, "
> "Expected 0%03o", TESTDIR, dir_mode,
> - PERMS);
> + PERMS & ~S_ISGID);
> } else {
> tst_resm(TPASS,
> "Functionality of chmod(%s, %#o)
> successful",
> @@ -241,12 +241,12 @@ void setup()
> strerror(errno));
> }
>
> - if (chown(TESTDIR, nobody_u->pw_uid, bin_group->gr_gid) == -1)
> + if (chown(TESTDIR, nobody_u->pw_uid, nobody_u->pw_gid) == -1)
> tst_brkm(TBROK, cleanup, "Couldn't change owner of testdir: %s",
> strerror(errno));
>
> - /* change to nobody:nobody */
> - if (setegid(nobody_u->pw_gid) == -1 ||
> + /* change to nobody:bin */
> + if (setegid(bin_group->gr_gid) == -1 ||
> seteuid(nobody_u->pw_uid) == -1)
> tst_brkm(TBROK, cleanup, "Couldn't switch to nobody:nobody: %s",
> strerror(errno));
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
