Hi Francesco, >I'm not sure about your patch.
>I've introduced the usage of such env variables to support cross-build of LTP. Yes I have reviewed your patch. >In fact, in case the results of LTP session was related to cross-execution, >the >infiormation about KERNEL_VERSION and MACHINE_ARCHITECTURE have to >be >referred to the target and not to the host. Do you agree ? Yes. I agree with you. I have been using LTP for Target Board executions not on Host Machine. As per my understating KERNEL_VERSION and MACHINE_ARCHITECTURE are should come from env right? But I could not print these variables in HTML file. Please refer the results published in LTP download page for 31-May-2009 release. http://sourceforge.net/project/platformdownload.php?group_id=3382 LTP Results: ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-ppc64.tgz ltp-full-20090531_results_kernel-2.6.18-128.el5_architecture-x86_64.tgz ltp-full-20090531_results_kernel-2.6.18-128.el5PAE_architecture-i386.tgz ltp-full-20090531_results_kernel-2.6.23.13_architecture-ia64.tgz ltp-full-20090531_results_kernel-2.6.27.19-5-default_architecture-i386.tgz None of the above results got printed these two KERNEL_VERSION and MACHINE_ARCHITECTURE variables in HTML. >With your fix, by using "uname -r" and "uname -m", to avoid to report wrong >>information, you have to run the "genhtml.pl" script over the target system >because if >you run the genhtml.pl on the host, you will get wrong information >about the kernel >version and machine architecture. No. As per my understanding to make generic script “uname -r" and "uname -m" are best way of use. All the target Machines are wont have full “env” support to extract KERNEL_VERSION and MACHINE_ARCHITECTURE info. Ofcourse my target Machine can not extract these variables. "uname -r" and "uname -m" are from target not from Host I guess. Because runltp script will runs on target so obviously genhtml.pl will run when –g option is specified. “ #sh runltp –g ltp-full-results-file.html” >Moreover, the assumption to run genhtml.pl over the target is not safe as >often the target >systems are embedded systems which do not support PERL. Yes. That is true. When we run runltp with –g option to create HTML file the person using this option should have knowledge that this script will use PERL script if there is no PERL no HTML file will generate right? >With the fix I've proposed and accepted, the LTP-user by means of the simple >env >variables, can define the right information to be reported on the LTP >results table about >kernel version and machine architecture. I have attached my HTML output file after and before patch. Please share your commands for ltp executions and results HTML file and other files. Before and after your patch. if i miss something please let me know. Best regards, Naresh >Now, by taking into account what above mentioned, I've to suggest to do not >apply your >proposal patch. >Best Regards, >Francesco On Thu, Jun 18, 2009 at 2:40 PM, Francesco RUNDO<[email protected]> wrote: > Hi, > > I'm not sure about your patch. > > I've introduced the usage of such env variables to support cross-build of > LTP. > > In fact, in case the results of LTP session was related to cross-execution, > the infiormation about KERNEL_VERSION and MACHINE_ARCHITECTURE have to be > referred to the target and not to the host. Do you agree ? > > With your fix, by using "uname -r" and "uname -m", to avoid to report wrong > information, you have to run the "genhtml.pl" script over the target system > because if you run the genhtml.pl on the host, you will get wrong > information about the kernel version and machine architecture. > > Moreover, the assumption to run genhtml.pl over the target is not safe as > often the target systems are embedded systems which do not support PERL. > > With the fix I've proposed and accepted, the LTP-user by means of the simple > env variables, can define the right information to be reported on the LTP > results table about kernel version and machine architecture. > > Now, by taking into account what above mentioned, I've to suggest to do not > apply your proposal patch. > > Best Regards, > Francesco > > naresh kamboju wrote: > >> Hi, >> >> I have noticed following issue and fixed. >> 1. Kernel Version >> 2. Machine Architecture. >> >> Please find the patch below and as attachment. >> >> Best regards >> Naresh Kamboju >> >> Signed-off-by: Naresh Kamboju < [email protected] > >> >> diff -Naurb a/tools/genhtml.pl b/tools/genhtml.pl >> --- a/tools/genhtml.pl 2009-04-02 12:07:28.000000000 +0530 >> +++ b/tools/genhtml.pl 2009-06-18 00:33:46.000000000 +0530 >> @@ -246,8 +246,12 @@ >> print "<tr><td><strong>Total Test TWARN</strong></td><td><strong> >> $warn_test_counter </strong></td></tr>\n"; >> print "<tr><td><strong>Total Test TRETR</strong></td><td><strong> >> $retr_test_counter </strong></td></tr>\n"; >> print "<tr><td><strong>Total Test TCONF</strong></td><td><strong> >> $conf_test_counter </strong></td></tr>\n"; >> -print "<tr><td><strong>Kernel Version</strong></td><td><strong> >> $ENV{KERNEL_VERSION} </strong></td></tr>\n"; >> -print "<tr><td><strong>Machine Architecture</strong></td><td><strong> >> $ENV{MACHINE_ARCH} </strong></td></tr>\n"; >> +print "<tr><td><strong>Kernel_Version</strong> </td> <td><strong>"; >> +$kernel_version=system("uname -r"); chop($kernel_version); >> +print " $kernel_version </strong></td></tr>\n"; >> +print "<tr><td><strong>Machine_Arch</strong> </td> <td><strong>"; >> +$machine_arch=system("uname -m"); chop($machine_arch); >> +print " $machine_arch </strong></td></tr>\n"; >> print "<tr><td><strong>Hostname</strong> </td> <td><strong>"; >> $hostname=system("uname -n"); chop($hostname); >> print " $hostname >> </strong></td></tr></tbody></table></div></body></html>\n"; >> > >Title: Linux Test Project - Results
LTP Output/Log (Report Generated on Fri Jun 19 05:26:28 JST 2009)
| PASSED | FAILED | WARNING | BROKEN | RETIRED | CONFIG-ERROR |
Meaning of the following KEYWORDS in test results/logs:
Detailed Report
| No | Test-Name | Start-Time | Command-Line | Contacts | Analysis | Initiation-Status | Test-Output | Duration | Termination-type | Termination-id | Core-File | cutime | cstime |
1 |
accept01 |
Fri Jun 19 05:26:28 2009 |
"accept01" |
"" |
exit |
"ok" |
accept01 1 PASS : bad file descriptor successful accept01 2 PASS : bad file descriptor successful accept01 3 PASS : invalid socket buffer successful accept01 4 PASS : invalid salen successful accept01 5 PASS : invalid salen successful accept01 6 PASS : no queued connections successful accept01 7 PASS : UDP accept successful incrementing stop | 0 |
exited |
0 |
no |
1 |
0 |
Summary Report
| Test Summary | Pan reported all Test Pass |
| LTP Version | LTP-20090531 |
| Start Time | Fri Jun 19 05:26:28 JST 2009 |
| End Time | Fri Jun 19 05:26:28 JST 2009 |
| Log Result | /mnt/ltp-full-20090531/results |
| Output/Failed Result | /mnt/ltp-full-20090531/output |
| Total Tests | 1 |
| Total Test TPASS: | 1 |
| Total Test TFAIL: | 0 |
| Total Test TBROK | 0 |
| Total Test TWARN | 0 |
| Total Test TRETR | 0 |
| Total Test TCONF | 0 |
| Kernel_Version | 2.6.29.1-alp_nl-kzm-arm11 |
| Machine_Arch | armv6l |
| Hostname | 43.88.101.207 |
LTP Output/Log (Report Generated on Fri Jun 19 05:22:40 JST 2009)
| PASSED | FAILED | WARNING | BROKEN | RETIRED | CONFIG-ERROR |
Meaning of the following KEYWORDS in test results/logs:
Detailed Report
| No | Test-Name | Start-Time | Command-Line | Contacts | Analysis | Initiation-Status | Test-Output | Duration | Termination-type | Termination-id | Core-File | cutime | cstime |
1 |
accept01 |
Fri Jun 19 05:22:40 2009 |
"accept01" |
"" |
exit |
"ok" |
accept01 1 PASS : bad file descriptor successful accept01 2 PASS : bad file descriptor successful accept01 3 PASS : invalid socket buffer successful accept01 4 PASS : invalid salen successful accept01 5 PASS : invalid salen successful accept01 6 PASS : no queued connections successful accept01 7 PASS : UDP accept successful incrementing stop | 0 |
exited |
0 |
no |
0 |
0 |
Summary Report
| Test Summary | Pan reported all Test Pass |
| LTP Version | LTP-20090531 |
| Start Time | Fri Jun 19 05:22:40 JST 2009 |
| End Time | Fri Jun 19 05:22:40 JST 2009 |
| Log Result | /mnt/ltp-full-20090531/results |
| Output/Failed Result | /mnt/ltp-full-20090531/output |
| Total Tests | 1 |
| Total Test TPASS: | 1 |
| Total Test TFAIL: | 0 |
| Total Test TBROK | 0 |
| Total Test TWARN | 0 |
| Total Test TRETR | 0 |
| Total Test TCONF | 0 |
| Kernel Version | |
| Machine Architecture | |
| Hostname | 43.88.101.207 |
------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
