Hi Subrata, I will wait for Kamalesh comments.
Thanks for your suggestion. I thought that [PATCH 00/N] can be used at the time of new test cases proposed. I have sent [FIX PATCH] that is the reason. Can we have a different kind of representation for New Test cases and Fix patch. Or is it a standard? Please provide me the link for standard. Your suggestions are welcome :) Best regards Naresh Kamboju On Thu, Jun 18, 2009 at 11:01 PM, Subrata Modak<[email protected]> wrote: > Great to see you fix these issues and send across the fixes. However, i > remember Kamalesh working on similar type of fixes. > > Lets hear from Kamalesh, whether he has something additional from this > series of patches, or, some other fixes in each patch apart from what > you have already provided. > > Kamalesh, > > Would you like to say something here ? > > Another suggestion. Naresh, next time when you send patches pertaining > to one particular issue observed in several tests, then no. the patches, > like [PATCH 00/N] to [PATCH N/N]. > > Regards-- > Subrata > > On Thu, 2009-06-18 at 01:48 +0530, naresh kamboju wrote: >> Hi, >> >> I have noticed following failures and fixed. >> 1. add_key01.c >> 2. add_key02.c >> >> >> Please find the patch below and as attachment. >> >> Best regards >> Naresh Kamboju >> >> Signed-off-by: Naresh Kamboju < [email protected] > >> diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c >> b/testcases/kernel/syscalls/add_key/add_key01.c >> --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 >> 23:39:37.000000000 +0530 >> +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17 >> 23:00:15.000000000 +0530 >> @@ -125,7 +125,7 @@ >> for (lc = 0; TEST_LOOPING(lc); ++lc) { >> Tst_count = 0; >> for (testno = 0; testno < TST_TOTAL; ++testno) { >> - TEST(result = syscall(286, "keyring", "wjkey", >> NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() >> + TEST(result = syscall(__NR_add_key, "keyring", >> "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() >> if(TEST_RETURN != -1) { >> tst_resm(TPASS, "add_key call succeeded"); >> cleanup(); >> @@ -139,4 +139,3 @@ >> } >> tst_exit(); >> } >> - >> diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c >> b/testcases/kernel/syscalls/add_key/add_key02.c >> --- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21 >> 23:40:50.000000000 +0530 >> +++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-17 >> 23:47:48.000000000 +0530 >> @@ -140,7 +140,7 @@ >> for (testno = 0; testno < TST_TOTAL; ++testno) { >> >> for(i=0; i<test_count; i++) { >> - TEST(syscall(286, test_cases[i].type, >> test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, >> KEY_SPEC_USER_KEYRING)); //call add_key() >> + TEST(syscall(__NR_add_key, test_cases[i].type, >> test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, >> KEY_SPEC_USER_KEYRING)); //call add_key() >> if(TEST_RETURN != -1){ >> tst_resm(TINFO,"call add_key() with wrong >> args succeed, but should fail"); >> fail++; >> @@ -170,4 +170,3 @@ >> } >> tst_exit(); >> } >> - > > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
