On Tuesday 23 June 2009 16:50:20 Subrata Modak wrote:
> Do you see Jiriś patch:
>
>
> fixing those issues you are seeing. If yes, then it could be safe to
> check-in your patches. Please confirm.
>
> Regards--
> Subrata
>
> On Mon, 2009-06-22 at 01:58 +0530, naresh kamboju wrote:
> > Hi Subrata,
> >
> > please hold these patches.(Don't commit)
> > List of patches submitted in last week.
> >
> > ltp-fix-add_key.patch
> > ltp-fix-bdflush.patch
> > ltp-fix-keyctl.patch
> > ltp-fix-newuname.patch
> > ltp-fix-rt_sigprocmask.patch
> > ltp-fix-rt_sigsuspend.patch
> > ltp-fix-set_thread_area.patch
> > ltp-fix-set_tid_address.patch
> > ltp-fix-ssetmask.patch
> > ltp-fix-tkill.patch
> >
> > I have noticed build errors on different ARCH other than x86 ARCH.
> > i'll test with most of the ARCH and resubmit these patches with Multi
> > Architecture support and share with LTP on 23-June-2009 along with
> > results HTML.
Just a side note to this whole issue: I think these patches should have been
applied long ago. The fact that it makes the tests wrong is not an obstacle for
applying, IMHO - the tests are just as wrong without them. Even more, they are
wrong in many other areas (like immoderate use of the TEST macro without reason
even in places where it's incorrect, doubtful test logic, strange usage of test
status messages and last, but not least, really ghastly code style). And these
should be fixed one by one, and waiting only makes it take longer.
Regards
Jiri Palecek
------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
