On Friday 19 June 2009 10:12:15 Jiri Palecek > wrote: > -#include <stdio.h> > -#include <errno.h> > -#include <linux/unistd.h> > -#include <asm/ldt.h> > - > /* Harness Specific Include Files. */ > #include "test.h" > #include "usctest.h" > #include "linux_syscall_numbers.h" > - > -/* Extern Global Variables */ > -extern int Tst_count; /* counter for tst_xxx routines. > */ -extern char *TESTDIR; /* temporary dir created by > tst_tmpdir() */ +#include "config.h" > > /* Global Variables */ > char *TCID = "set_thread_area01"; /* Test program identifier.*/ > int testno; > int TST_TOTAL = 2; /* total number of tests in this > file. */ > > +#if defined HAVE_ASM_LDT_H > +#include <stdio.h> > +#include <errno.h> > +#include <linux/unistd.h> > +#include <asm/ldt.h>
moving asm/ldt.h behind the ifdef makes sense, but none of the others do. there is no point in delaying the other includes and in general, all includes should come first ... there shouldnt be definitions before them. less likely to get bitten in the ass with clashes. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
